-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not compile in C++17 #56
Comments
can u fix it with pr? |
I don't know what this class does (how to replace it) and the original nanogui does not have this file. So I used another GUI library instead. |
Sure, is it new version? |
Something like a new version with an other problem: class StackAllocator : public std::allocator<T> { https://en.cppreference.com/w/cpp/memory/allocator So isn't work with c++20 But is there anyway. Line 75 in 6785c6b
|
I think std::allocator_traits can replace std::allocator. Nanogui-sdl uses std::allocator in some other places and replacing those was recommended by Visual Studio. https://en.cppreference.com/w/cpp/memory/allocator_traits According to this, std::allocator is removed because it is (at least partially) duplicate of std::allocator_traits: https://stackoverflow.com/questions/39414610/why-are-are-stdallocators-construct-and-destroy-functions-deprecated-in-c17 |
std::unary_function is removed in C++17, therefore nanort.h does not compile. https://en.cppreference.com/w/cpp/utility/functional/unary_function
Tested in Visual Studio 2022.
The text was updated successfully, but these errors were encountered: