Introduce a new --dbname-filter flag #256
Conversation
|
Hi, I was thinking about adding more filters, it's great you made this patch ! Thx a lot for the patch. |
|
Just tested it; works as expected. Maybe we should add that the regexp are documented in the following link in a FAQ entry and/or in the man page ? |
|
If we want to add more filters, maybe it'd be nicer to have a single |
|
@blogh Thanks for verifying that it works! But about adding the link to regex docs...probably just overkill...as the people using this tool, especially the more exotic flags, are already very technical people and surely know what a regex means / looks like :) |
|
@dlax Sure, not against the idea...but then the architecture for such generic filters probably needs to come from your side. |
|
@kmoppel I am not sure about that, but we can wait about the questions and add the FAQ entry then. |
|
Added the generic |
|
I like the changes :) |
dlax
force-pushed
the
introduce-dbname-filter-flag
branch
from
c404358
to
32a8f8d
Compare
|
I've cleaned up the git history. (I'll fix the lint issue, due to mypy new version, in the meantime.) |
If specified the input will be matched as Postgres regex against all fetched activites - DB info, normal activities and waiting / blocking info. A star (*) in the UI for the DATABASE column will hint at the option being active.
The fixture is not needed as we can just build a new "data" object in the test. Also compare active connections with and without filtering.
dlax
force-pushed
the
introduce-dbname-filter-flag
branch
from
32a8f8d
to
5011745
Compare
Allows to blend out any activities from DBs that are not of interest - DB size, TPS, running / waiting / blocking queries. To understand when a regex filter is specified I've added a star (*) to the DATABASE column...hopefully this is enough. Looks like that:
