Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to 0 for required Attributes #53

Merged
merged 1 commit into from
Mar 3, 2024
Merged

Conversation

cole-maclean
Copy link
Contributor

Required parameters needed defaults after firmware update, integration started working after this change.

@dalinicus dalinicus merged commit f9a808f into dalinicus:main Mar 3, 2024
@dalinicus
Copy link
Owner

My git client screwed up the merge, but I added some tests for your change. Did some spot manual testing and everything seems good 👍🏻

I'm wondering if this isn't related to the issues we were seeing with #39. There could be other fields that may need defaults added.

I'll push this out as version 1.4.2. Thanks for the contribution :)

@dalinicus dalinicus added the bug Something isn't working label Mar 3, 2024
@dalinicus dalinicus self-assigned this Mar 3, 2024
@dalinicus dalinicus self-requested a review March 3, 2024 17:34
@dalinicus dalinicus removed their assignment Mar 3, 2024
@cole-maclean
Copy link
Contributor Author

Oh I should have added tests, thanks for those! I'm not too sure if this is related to #39, the error I was getting back was a 400, and details were a javascript parsing error trying to convert Strings to Ints on value None. I went to reproduce the log but reverting the changes in this PR locally, the error didn't reproduce, so I wonder if this is only a bug on initial setup of the integration. Bit of a weird one!

Thanks again for all your work on this dalinicus!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants