fix(presets): early-catching for performance and bug reasons

dalisoft · Apr 25, 2024 · d5bfaba · d5bfaba
1 parent 5cebfb9
commit d5bfaba
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/presets/conventional-commits.sh b/presets/conventional-commits.sh
@@ -41,10 +41,12 @@ parse_commit() {
     type="BREAKING CHANGE"
     scope="${BASH_REMATCH[3]}"
     description="${BASH_REMATCH[4]}"
+  else
+    return 0
   fi
 
   # Extract body
-  if [[ "$body" =~ $string_commit_major ]]; then
+  if [[ -n "$body" && "$body" =~ $string_commit_major ]]; then
     type="BREAKING CHANGE"
     description="$subject"
   fi
@@ -67,6 +69,8 @@ parse_commit() {
       MAJOR_UPGRADED=true
       RELEASE_BODY+="\n## BREAKING CHANGES\n\n"
     fi
+  else
+    return 0
   fi
 
   RELEASE_BODY+="- "

diff --git a/presets/workspace.sh b/presets/workspace.sh
@@ -36,12 +36,12 @@ parse_commit() {
     type="${BASH_REMATCH[1]}"
     scope="${BASH_REMATCH[3]}"
     description="${BASH_REMATCH[4]}"
-
   elif [[ "$subject" =~ $regexp_commit_major ]]; then
     type="BREAKING CHANGE"
     scope="${BASH_REMATCH[3]}"
     description="${BASH_REMATCH[4]}"
-
+  else
+    return 0
   fi
 
   # Early catching non-workspace commits
@@ -50,7 +50,7 @@ parse_commit() {
   fi
 
   # Extract body
-  if [[ "$body" =~ $string_commit_major ]]; then
+  if [[ -n "$body" && "$body" =~ $string_commit_major ]]; then
     type="BREAKING CHANGE"
     description="$subject"
   fi