Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client Side Authentication Added #481

Merged
merged 5 commits into from
Jul 20, 2018
Merged

Conversation

MuniekMg
Copy link
Contributor

@MuniekMg MuniekMg commented Mar 9, 2018

Added client certificate for SSL Client Side Authentication with a few methods to obtain it by various of inits.

@ghost
Copy link

ghost commented Mar 12, 2018

@daltoniam can you check it?

@daltoniam
Copy link
Owner

Looks good! I released a new version for Swift 4.1 support and that appears to created a conflict 😞. A few things I might suggest changing with the conflict updated:

  • No print statements. Those errors should be bubbled up so we can return it to the user.
  • I think we can remove the useSSLClientAuthentication. The optional sslClientCertificate I think should suffice.

Again looks great, just a few small things 😄.

@MuniekMg
Copy link
Contributor Author

MuniekMg commented Apr 7, 2018

@daltoniam All Done! :)

@fsuc
Copy link

fsuc commented Apr 25, 2018

Thanks for this pull request. Can we add another initializer to pass data and password ?

@MuniekMg
Copy link
Contributor Author

@fsuc I think it's question to owner @daltoniam

@AdamMak
Copy link

AdamMak commented May 8, 2018

Any updates on when this is likely to be approved? Would really like to have this added to Starscream as I require this for my current project.

@sum98044
Copy link

me too. client certificate authentication is getting popular.
It would be great it can be approved.

@pioole
Copy link

pioole commented May 30, 2018

+1

@daltoniam
Copy link
Owner

I'm finally gonna merge this 😄. I still need to do some testing, but I'm going to do that apart of my 4.0.0 release with the Network.framework. Great work and sorry about the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants