Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update NetwokStream to support wss SSL valid cert #607

Closed
wants to merge 1 commit into from

Conversation

bukira
Copy link

@bukira bukira commented Jan 10, 2019

change "false" to "true" for isValidSSLCertificate() in NetworkStream
This allows NetworkStream to work with WSS web sockets and valid SSL certs.
Apple automatically checks certs so no manual check is required

@bukira bukira changed the title update NetwokStream to suppler wss SSL valid cert update NetwokStream to support wss SSL valid cert Jan 10, 2019
@fassko fassko self-requested a review January 17, 2019 16:36
Copy link
Collaborator

@fassko fassko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR creates a new file. Please change file in Sources/Starscream/

@bukira
Copy link
Author

bukira commented Jan 25, 2019

I have no idea how to do that, I tried with the PullRequest which obviously didn't work, but as you can see from the commit its only a one word change, anyone can make the change

@fassko
Copy link
Collaborator

fassko commented Feb 11, 2019

@bukira you need to edit existing file in Sources/Starscream/NetworkStream.swift

Right now you have added that file in home directory.

@bukira
Copy link
Author

bukira commented Feb 11, 2019

@fassko

Yes but I have no idea how to do that, I gave it a go and obviously it wasn't right, as I have no idea how to do what your asking I can't do.

All I request is 1 word change from "false" to "true"

@fassko
Copy link
Collaborator

fassko commented Feb 11, 2019

@bukira you need to clone xcode-10 branch and edit file Sources/Starscream/NetworkStream.swift

@bukira
Copy link
Author

bukira commented Feb 11, 2019

Thats exactly what I did

@fassko
Copy link
Collaborator

fassko commented Feb 11, 2019

If you check files changed then you can see that NetworkStream.swift has moved to home dir

@acmacalister
Copy link
Collaborator

See PR #653. It refactored all this logic and has certificate pinning support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants