Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the deadlock issue on iOS 11 #764

Merged

Conversation

ameyjain
Copy link
Contributor

If the swift version is less than 5.0 instead of calling the default function: https://developer.apple.com/documentation/swift/2632391-withunsafemutablebytes
it calls itself causing a deadlock.

@jagdeep-manik
Copy link

+1, I ran into the same issue. It'll cause an infinite loop. @daltoniam

As an aside, the way swift package manager is set up makes it so that it builds using swift 4.2 even though we could technically support swift 5. I wish there was a way to tell SPM to build with this with swift 5. 😬

I'm also wondering if we need those version checks in the first place--it looks like all those functions in those helpers are available in swift 4. Does swift 5 require some different memory management that forces us to have special handling?

@amayers
Copy link
Contributor

amayers commented Jun 17, 2020

The reason that SPM is building it with 4.2, is because this line at the top of Package.swift.

// swift-tools-version:4.2

I just opened #797 to update it to 5.2, since if you install via Cocoapods it will be using 5.0, and everything builds/tests fine on 5.2.

@daltoniam
Copy link
Owner

Thanks! Appreciate the PR!

@daltoniam daltoniam merged commit 0c7e7ab into daltoniam:master Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants