Fix compile error on Xcode 12 #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now you can build on both Xcode 11.5 & 12.0 b1. On 12, the unit tests would fail to compile because it wasn't finding the `Starscream` framework. So I added `Starscream` as a dependency of the test target. In `FoundationHTTPServerHandler` the `method` is of type `CFString`, while `getVerb` is `NSString`. Looks like Xcode 12 doesn't like equality comparison between those types without a cast as `NSString`.
|
Can someone merge this? |
|
TBH the slow response to this simple PR caused me to reevaluate our needs, and I found that I totally get that it is likely a side project for someone, and so they must prioritize accordingly. |
|
@daltoniam the code change here looks good |
|
Thanks! |
|
Hey guys, shouldn't we bump up the podspec version for this fix? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now you can build on both Xcode 11.5 & 12.0 b1.
On 12, the unit tests would fail to compile because it wasn't finding the
Starscreamframework. So I addedStarscreamas a dependency of the test target.In
FoundationHTTPServerHandlerthemethodis of typeCFString, whilegetVerbisNSString. Looks like Xcode 12 doesn't like equality comparison between those types without a cast asNSString.