Removed redundant styling for embeds (Can now change max embed height…

… with the default variable alone `--embed-max-height`)
damiankorcz · Aug 12, 2023 · dac4a55 · dac4a55
1 parent 25ce342
commit dac4a55
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 11 deletions.
diff --git a/src/scss/Editor/editorStyling.scss b/src/scss/Editor/editorStyling.scss
@@ -269,18 +269,7 @@ ul > li.task-list-item .task-list-item-checkbox {
 	}
 }
 
-// Limiting the max height of the internal file embed
-.markdown-preview-view .markdown-embed,
-.markdown-preview-view .file-embed,
-.internal-embed.is-loaded:not(.image-embed) {
-	display: flex;
-	flex-direction: column;
-	max-height: 800px;
-	overflow: auto;
-}
-
 .embed-title {
-	position: sticky;
 	top: 0;
 	z-index: var(--layer-cover);
 	width: 100%;

diff --git a/src/scss/Variables/coreVariables.scss b/src/scss/Variables/coreVariables.scss
@@ -132,6 +132,8 @@ body {
 
 	--collapse-icon-color-collapsed: var(--text-normal);
 
+	--embed-max-height: 800px;
+
 	// Style Settings Defaults
 	--status-bar-background-color-lt: #EBECEF;
 	--status-bar-background-color-dt: #2B2B2B;