Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local graph becomes black after changing mode (dark/light) #133

Closed
kudrmax opened this issue Jul 27, 2023 · 5 comments
Closed

Local graph becomes black after changing mode (dark/light) #133

kudrmax opened this issue Jul 27, 2023 · 5 comments
Assignees
Labels
Bug Something isn't working / doesn't look right

Comments

@kudrmax
Copy link

kudrmax commented Jul 27, 2023

Describe the bug

After changing theme mode from dark to light or from light to dark colors of any part of local graph becomes black. If go to Style Setting tab -> Prism Theme -> Appearance -> Graph Color Customisation -> Graph lines color and press Restore default button, then bug disappears.

To Reproduce

  1. Open local graph
  2. Change theme mode (light/dark)

Screenshots

Before:
image

After:
image
image

Setup Information

  • Device Type: Mac
  • Operating System: MacOS Monterey
  • Prism version: 3.3.0
  • Color Schemes Used: Swan
  • Obsidian Version: 1.3.5
  • Obsidian Installer Version: 1.3.5

Additional context

I tested this bug in empty new vault without any other plugin accept Style Setting, and bug still exists.

@kudrmax kudrmax added the Bug Something isn't working / doesn't look right label Jul 27, 2023
@garbosz
Copy link

garbosz commented Apr 18, 2024

+1 on this

Setup Information

  • Device Type: laptop
  • Operating System: Windows 11
  • Prism version: 3.5.0
  • Color Schemes Used: pistachio/pine
  • Obsidian Version: 1.5.12
  • Obsidian Installer Version: 1.4.13

@kazerniel
Copy link

Mine has the right colours at launch, then after a few seconds it switches to all black regardless of dark/light mode. (I usually have mode set to 'adapt to system', but it behaves the same at any mode setting.)

@FeralFlora
Copy link

I keep wondering about the colors of the local graph (or lack thereof), and then I remember this issue. Would love to see this fixed, as it's one of the few drawbacks of the Prism theme.

@damiankorcz
Copy link
Owner

I think I've finally identified the issue. Still have a few things to resolve but there will at least be a partial fix for this that prevents the colours from disappearing in the next update 🥳

@damiankorcz
Copy link
Owner

Hi all,
The partial fix should now be available in Prism 3.5.3. The update requires Obsidian app version 1.6.0 or above.

The current problem is that if you switch between Light / Dark theme the graph colours will use the shades from Swan / Raven colour schemes since the partial fix was to make those the default colours which other colour schemes replace. Strangely if you change any setting in Style Settings it triggers a reload of some kind that will load the correct colour scheme colours. Not sure how I will resolve this yet so for now it's something we'll have to deal with. I can only assume these issues are due either how Obsidian loads graph colours, how Style Settings injects the CSS or a combination of both.

Since the issue outlined has been addressed I'll close this issue but will continue to look for a solution to the above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working / doesn't look right
Projects
None yet
Development

No branches or pull requests

5 participants