Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected filters should be added to search box in a user-friendly way #22

Closed
7 tasks done
damianmoore opened this issue Dec 31, 2018 · 3 comments · Fixed by #162
Closed
7 tasks done

Selected filters should be added to search box in a user-friendly way #22

damianmoore opened this issue Dec 31, 2018 · 3 comments · Fixed by #162
Assignees
Milestone

Comments

@damianmoore
Copy link
Collaborator

damianmoore commented Dec 31, 2018

AC:

  • Each selected filter drawn within a box in the search box, nicely styled
  • Icon signifying each type of filter
  • The box has a cross to remove the filter
  • Search box needs to grow vertically when many are selected
  • Range values should show one box with an updating number range
  • Range value box should be removed when slider has been expanded to the extent that it is no longer performing any filtering
  • Icon to clear all filters
@LukeDeaves
Copy link
Contributor

In addition to the box having a cross to remove the filter, a "Clear" box (or cross at the end of the row or similar) which clears all filters would be good.

@damianmoore
Copy link
Collaborator Author

Yep, good call to have a "clear all" cross. Thanks!

@damianmoore damianmoore self-assigned this Feb 24, 2019
@damianmoore damianmoore pinned this issue Feb 24, 2019
@damianmoore damianmoore unpinned this issue Feb 24, 2019
@damianmoore
Copy link
Collaborator Author

damianmoore commented Dec 23, 2020

@GyanP Please take a look at the range values first. A range slider widget is required for Aperture, Exposure, ISO Speed and Focal Length filters.

This is how it looks at the moment but it is not ideal. It is filtering using AND rather than OR so if you select more than one aperture you will get no results.

Screenshot_2020-12-23 Photonix Photo Manager

This is how I would like the fields mentioned above to look, using Aperture as an example. The user should be able to drag the two handles of the slider to select the minimum and maximum values to filter by. I the search box there will only be one tag shown for each filter (aperture in this case) and it will show the range that's selected in the slider. If the two slider handles are pushed to either end then no filtering is being applied and the tag should be removed from the search bar.

Screenshot_2020-12-23 Photonix Photo Manager(2)

The QuaphQL queries will need to be updated to account for these changes. We have Chakra widgets installed and used elsewhere. They have a Slider widget https://chakra-ui.com/docs/form/slider but it doesn't seem like it's able to have two handles for selecting a range. You might find it useful to extend what is already there though.

@damianmoore damianmoore assigned GyanP and unassigned damianmoore Dec 23, 2020
@damianmoore damianmoore linked a pull request Jan 12, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants