Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ffmpeg executable path configurable #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kodie
Copy link

@kodie kodie commented Dec 21, 2021

It seems like this package is abandoned but it still works better for me than the alternative for the project I'm currently working on. One thing I needed to be able to do is change the ffmpeg executable path so that it can work with ffmpeg-static, it seems like some effort was made to make this configurable (c099e37) however it was still hard-coded for the video object. So I went a different route.

The bin is now a setting that can be configured like this:

const pathToFfmpeg = require('ffmpeg-static')
const ffmpeg = require('ffmpeg')

const video = await new ffmpeg(filePath, { bin: pathToFfmpeg })

I cut my branch from the 46e8bb5 commit as that is the latest version that is published to NPM (I also couldn't get what's currently on the repo to work).

Even though this package is abandoned I figured I'd still put up the PR just in case anyone else runs into this issue.

You can use my version of this package which is the current version on NPM with the added configurable bin by placing this under the dependencies in your package.json file:

"ffmpeg": "git@github.com:kodie/node-ffmpeg.git#kodie/fix-bin-path"

@kodie kodie mentioned this pull request Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant