Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed fix for damianszczepanik/cucumber-reporting#675 #712

Merged
merged 1 commit into from Mar 22, 2018

Conversation

KLBonn
Copy link
Contributor

@KLBonn KLBonn commented Mar 22, 2018

Issue #675 was closed because of missing functional impact.
But that ERROR log message still is there and initially confuses every colleague looking at the output.

A simple fix would be supplying an appropriate LOG4J config file (like you do already for unit tests).

@codecov-io
Copy link

codecov-io commented Mar 22, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@77adbf8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #712   +/-   ##
=========================================
  Coverage          ?   98.42%           
  Complexity        ?      445           
=========================================
  Files             ?       44           
  Lines             ?      953           
  Branches          ?       77           
=========================================
  Hits              ?      938           
  Misses            ?        7           
  Partials          ?        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77adbf8...c1da6ca. Read the comment docs.

@damianszczepanik damianszczepanik merged commit 195347f into damianszczepanik:master Mar 22, 2018
@damianszczepanik
Copy link
Owner

Happy to see this PR - thank you

@KLBonn KLBonn deleted the log4j2_config branch March 26, 2018 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants