Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exception when embeddingDirectory not present and not created #718

Closed
wants to merge 1 commit into from
Closed

Conversation

aravinder111
Copy link
Contributor

Check if embeddingDirectory can be created, otherwise throw ValidationException

sibling PR related to issue jenkinsci/cucumber-reports-plugin#213: #717

Check if embeddingDirectory can be created, otherwise throw ValidationException
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@f0c78c7). Click here to learn what that means.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #718   +/-   ##
=========================================
  Coverage          ?   98.02%           
  Complexity        ?      448           
=========================================
  Files             ?       45           
  Lines             ?      963           
  Branches          ?       79           
=========================================
  Hits              ?      944           
  Misses            ?        9           
  Partials          ?       10
Impacted Files Coverage Δ Complexity Δ
...java/net/masterthought/cucumber/ReportBuilder.java 91.86% <33.33%> (ø) 21 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0c78c7...f895ab3. Read the comment docs.

Copy link

@docwhat docwhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pulled out of #693, right? 👍 Good job keeping the author as @AndyGee.

@damianszczepanik
Copy link
Owner

When this problem could happen? I'm fine with this change as long as I'm convinced that there is no other way to fix the source of the problem

@aravinder111
Copy link
Contributor Author

@AndyGee Can you provide your input on @damianszczepanik question above ??

I haven't observed this personally, but mkdirs() can return false when it fails to create dirs because of permission level. So throwing an Exception when that happens would be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants