-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing table schema #26
Comments
You could do this in the context cheers Damien |
I know but how can I make this a parameter so everyone can choose its
schema ? We can make it by default if you think it's wise
Le 20 janv. 2017 9:36 PM, "damienbod" <notifications@github.com> a écrit :
… You could do this in the context
https://github.com/damienbod/AspNet5Localization/blob/
master/AspNet5Localization/src/Localization.SqlLocalizer/
DbStringLocalizer/LocalizationModelContext.cs
cheers Damien
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#26 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABS8esndx5wJfdVF3S9qnz3mc4fDSw9dks5rURregaJpZM4Lpgy_>
.
|
@RemiBou We could create another constructor on the LocalizationModelContext which takes an new interface or class as a param, which would be used instead of the default class registered in the extensions class... This can be used to set the schema stuff on the LocalizationModelContext. This would then need to be set in the IoC in the right order. Not sure if this is good. Or we could just create a static property on the LocalizationModelContext class. |
We might create an Option class so the user can change the table names or even add a a callback to this options expecting the modelbuilder in the parameters so everyone can add what they want. |
@RemiBou thanks |
Thanks, I'll create the package and the docs today Thanks for the changes Greetings Damien |
@RemiBou I have problems using the new schema changes, the demo apps don't work due to IoC problems. I moved your changes to the devSchema branch, and will try to debug. https://github.com/damienbod/AspNet5Localization/tree/devSchema |
@RemiBou done https://www.nuget.org/packages/Localization.SqlLocalizer/1.0.7 services.AddLocalizationSqlSchema("translations");
services.AddDbContext<LocalizationModelContext>(options =>
options.UseSqlite(
sqlConnectionString,
b => b.MigrationsAssembly("AspNet5Localization")
)
); |
Great ! Thank you
2017-02-05 18:18 GMT+01:00 damienbod <notifications@github.com>:
… @RemiBou <https://github.com/RemiBou> done
https://www.nuget.org/packages/Localization.SqlLocalizer/1.0.7
services.AddLocalizationSqlSchema("translations");services.AddDbContext<LocalizationModelContext>(options =>
options.UseSqlite(
sqlConnectionString,
b => b.MigrationsAssembly("AspNet5Localization")
)
);
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#26 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABS8etBzaJNFjCZILqDEsU-kY5-JRWCWks5rZgRzgaJpZM4Lpgy_>
.
--
Rémi BOURGAREL
Téléphone : +33 6 95 25 45 60
Adresse : 99 Avenue Emmanuel Maignan , 31 200 Toulouse, France
|
Hi, given the generic names (ExportHistory,ImportHistory) it would be nice to be able to change the schema containing the tables.
I don't know how I should do this, with a short explanation i can send PR.
The text was updated successfully, but these errors were encountered: