urlHandler callback function parameter in LogoffRevocationService.logoff does nothing

[Lexa-tech]

Hello, I'm trying to add state parameter when calling logoff function.

The setState method in oidcService enable to pass this state parameter when calling authorize function, but this state is not added to the request when calling logoff functions.

That's why I'm trying to use urlHandler callback function parameter in logoff function, but it seems that it does nothing.

angular-auth-oidc-client/projects/angular-auth-oidc-client/src/lib/logoffRevoke/logoff-revocation.service.ts

Line 27 in 23ed172

logoff(urlHandler?: (url: string) => any) {

Describe the bug
Impossible to add customParameter in logoff function.

• setState in OIDCService is not applied when calling logoff function
• urlHandler callback function param does nothing in logoff function

Expected behavior
Pass state parameter when calling logoff functions

Desktop (please complete the following information):

• Browser [Chrome]

Thanks for your Help

[FabianGosebrink]

Hey @Lexa-tech , So your issue is that you want to add custom params to the logoff url, is that correct? Thanks :)

[Lexa-tech]

Exactly, I would like add state parameter when calling logoff function , the same way we can pass this state when calling the authorize function (with oidcService.setState ).
But If we can't use oidcService state, I don't mind using urlHandler callback function of logoff to add customParams.
Thanks.

[FabianGosebrink]

So something like logoff(..., customParams?: { [key: string]: string | number | boolean }) would be a fit for you? @damienbod what do you think?

[damienbod]

just need to check if the endsession endpoint allows custom parameters per spec.

cheers Damien

[Lexa-tech]

Couldn't you use the state that is set with the oidcService.setState method when calling logoff function ?
I don't mind using customParams, it's just a question for my comprehension of the oidc flow.

[Lexa-tech]

Hi @damienbod , did you find your answer about allowing custom parameters in the endsession endpoint ?

[FabianGosebrink]

We will implement that. Just did not find the time until now. This is a breaking change.

[FabianGosebrink]

Related #932

[FabianGosebrink]

Implemented, will be in Release 12.

[Lexa-tech]

Implemented, will be in Release 12.

Thanks @FabianGosebrink