Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed AuthorizedState enum #1062

Conversation

JerrettDavis
Copy link
Contributor

AuthorizedState should only ever be true or false, I have removed the AuthorizedState enum per issue #755.

@JerrettDavis
Copy link
Contributor Author

JerrettDavis commented Apr 25, 2021

It seems the library uses "authorized" and "authenticated" nearly interchangeably. I initially authored this with isAuthorized, but I believe isAuthenticated is more accurate, and it better adheres to similarly named responses in other areas.

On that note, is there any reason why "authorized" is used in place of "authenticated" in other places in the application? To my knowledge, these are different things.

Repository owner deleted a comment from inloox-dev Apr 25, 2021
@damienbod
Copy link
Owner

@JerrettDavis LGTM

@FabianGosebrink FabianGosebrink mentioned this pull request Apr 25, 2021
19 tasks
@FabianGosebrink
Copy link
Collaborator

FabianGosebrink commented Apr 25, 2021

Looks good to me as well. I am sure @damienbod will answer your questions. Could you in the meantime

  1. Target the V12-Branch to merge this PR into releaseV12-WIP. You have to merge V12 Branch into yours.
  2. Add a migration chapter to the migration doc. There is a file already in the V12-Branch. There a new chapter can be added. Migration V11 to V 12

Thanks!

@JerrettDavis JerrettDavis changed the base branch from main to releaseV12-WIP April 25, 2021 15:54
@JerrettDavis
Copy link
Contributor Author

I have corrected the target branch, merged thereleaseV12-WIP branch into mine, and updated the documentation accordingly. Please let me know if any other changes are needed.

Thanks!

@damienbod damienbod merged commit 7d61f9e into damienbod:releaseV12-WIP Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants