fix concurrent issue with renew and normal code flow #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suppose those build errors shouldn't be by my PR as I don't change any dependency, if I see that wrong, please let me know. |
|
I will check the dependency issue on another branch... |
|
If you merge main again into your branch, the dependency problems should be resolved. |
|
I merged the branch, with approval it will run the workflow again |
|
Looks good, doesn't it? :) @damienbod can you please verify if this is correct behavior? Code lgtm. Thanks for this PR!!! |
|
LGTM |
|
@Tom-V thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I tried to fix this issue myself: #1479
I tested it and it looks like it's behaving like it should.
Can you please check the pull request and guide me to improve it so it can be merged?
Kind regards