Bugfix/unable to extract jwk without kid #1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly throw error on several matches if neither keyId nor use is present
…input parameter enabling the return of an empty array instead of throwing an error when there are no matches
…ion without filtering on use if no matches. Using first match.
|
@damienbod Could you find the time to check out this PR? It's fixing what stops us from upgrading from Angular 13 |
| @@ -44,9 +44,9 @@ describe('JwkWindowCryptoService', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| beforeEach(() => { | |||
| beforeEach(async () => { | |||
There was a problem hiding this comment.
@FabianGosebrink Thanks for the feedback! How about now? 😄
|
Thanks @erichjsonfosse PR LGTM I do some manual testing and release, all goes well, this weekend One test is failing |
Thanks for the feedback @damienbod ! Managed to reproduce locally now. Working on it. |
|
@damienbod Both the |
|
Thanks so much @erichjsonfosse !!!!! ❣️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1339
Tests passing?: Affirmative
JwkExtractor, a service that conforms with RFC7517 when it comes to thekty,kidanduseclaims.JwkWindowCryptoService, a "sibling" toJwtWindowCryptoServiceTokenValidationService.validateSignatureIdTokento test for a successful resultDescription:
The
TokenValidationServicenow tries to extract keys based onktyanduse, andkidif it exists. If no matches are found, it tries to extract keys based onkty, andkidif it exists (ktyis required by the spec). If no matches are found, a sensible error is thrown. If matches are found, the first one is chosen, regardless of the number of matches.Tested
sample-code-flow-refresh-tokenssuccessfully with https://offeringsolutions-sts.azurewebsites.net when running the project locally.Let me know if anything is missing or not up to expectations, and I'll update the PR asap 👍