feat: support the data attribute inside the Guard #1767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rd to add custom params to the login request
|
Thanks for this PR! This is awesome! Can you also update the docs to document this new feature? Thanks again! To run the docs you have to navigate into the |
|
can you check the grammar. i tried to write it as simple as possible |
|
when will you have time to merge this request ? or is anything to be done before ? |
|
On it. |
|
when will the new version be available on npm |
|
We are planning a release this or next week. @damienbod ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now a dev can add custom params via the data attribute of the route