Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically enable sourcemaps #28

Closed
wireframe opened this issue Nov 19, 2015 · 8 comments
Closed

Automatically enable sourcemaps #28

wireframe opened this issue Nov 19, 2015 · 8 comments

Comments

@wireframe
Copy link

ember-cli disables sourcemaps in production mode which makes sentry's stacktraces pretty much unusable. It would be awesome to automatically enable sourcemaps with this addon so that stuff "just works".

If that's not possible or you'd want this to be an opt-in feature, it would be great to log a warning/error on startup that the deveoper needs to manually enable sourcemaps for sentry's stacktraces to be usable.

@hussfelt
Copy link
Contributor

I had no idea about this. Explains why our new test-app with sentry is not tracked!
Probably saved me quite some debugging-time. Thanks! 👍

@ghost
Copy link

ghost commented Nov 23, 2015

@wireframe I also had no idea about this.

I actually don't know how to do this, but I'll have a look into it. If you happen to know how to do this, feel free to submit a PR 🎄

@dschmidt
Copy link
Collaborator

Could be possible by the config hook of Ember Addon

@floqqi
Copy link
Contributor

floqqi commented Mar 7, 2016

Just for the people who came here to look for a solution:

// ember-cli-build.js

var app = new EmberApp(defaults, {
  sourcemaps: {
    enabled: true
  }
});

Will enable sourcemaps for every build (even production).

@ghost
Copy link

ghost commented Apr 27, 2016

🎉 if @floqqi's answer solves this.

@devinrhode2
Copy link

I included the sourcemaps: true option without testing that it was necessary, but in my sentry dashboard I do see stack traces with FULL function names, so I think it would be working.

@robclancy
Copy link

Why does the readme link to this issue instead of just saying to use sourcemaps directly?

@Turbo87
Copy link
Collaborator

Turbo87 commented Jun 22, 2019

@robclancy legacy. PRs welcome!

cbroeren added a commit to cbroeren/ember-cli-sentry that referenced this issue Oct 15, 2019
This will add a meaningful explanation for sourcemaps enabling instead of linking to issue ember-cli-sentry#28.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants