Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for different language on trailers #1

Closed
damienhaynes opened this issue Apr 8, 2014 · 2 comments
Closed

Support for different language on trailers #1

damienhaynes opened this issue Apr 8, 2014 · 2 comments
Assignees
@damienhaynes
Labels
enhancement

Comments

@damienhaynes
Copy link
Owner

Support for different language on trailers, this should now be possible with the new video API methods.

We should fallback to english when no localised trailers are found.
@damienhaynes damienhaynes self-assigned this Apr 8, 2014
@damienhaynes
Copy link
Owner Author

Language is an optional request parameter, currently we hard code to English i.e. "en", supported formatted are ISO 639-1 codes.

We can add a Language Dropdown for users to set preferred language, if not 'English' and request returns zero results we can do another request with it set to English.

@damienhaynes
Copy link
Owner Author

We could also have an option that requests in more than a single language, that way the user is presented with localised and other languages.

damienhaynes added a commit that referenced this issue Apr 29, 2014
@damienhaynes
#1: Added support for Trailers in different languages from TMDb.
11705b7 
Added language settings in the Configuration dialog under General Settings.
damienhaynes added a commit that referenced this issue Apr 29, 2014
@damienhaynes
#1: Added language code to trailer cache on any newly downloaded trai…
83ec7a1 
…lers.
damienhaynes added a commit that referenced this issue Apr 30, 2014
@damienhaynes
#1: Added language to filename for auto-downloads.
a4a30fc
damienhaynes added a commit that referenced this issue Apr 30, 2014
@damienhaynes
#1: Added language settings to Extensions GUI.
de974bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damienhaynes damienhaynes

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@damienhaynes