CableTest: Don't wait for voltage go to 0V but to <50V #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cschleifenbaum
force-pushed
the
master
branch
from
54a4d24
to
19d8718
Compare
cschleifenbaum
force-pushed
the
master
branch
from
909b2e9
to
458db19
Compare
We have ++I after the first check so add another one at the end.
This fixes the LIM not locking the charging cable in place anymore.
cschleifenbaum
force-pushed
the
master
branch
from
458db19
to
1731281
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And then wait it to be like that for two seconds. Switch to next state then.
Efacec charger was continuing to the next state when we were still waiting for the cable test voltage to drop to 0V.