Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Year panel selection with future false breaks #17

Open
VanessaKeeton opened this issue Jan 8, 2020 · 4 comments
Open

Year panel selection with future false breaks #17

VanessaKeeton opened this issue Jan 8, 2020 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@VanessaKeeton
Copy link

Year panel selection with future false causes browser to toss the long script warning. even if I set the yearsCount to 0. It should simply not show the future years but the right count of years in the past.

@lornacodes
Copy link

This is also the case for the Month panel selection

@damienroche damienroche self-assigned this Mar 3, 2020
@damienroche damienroche added the bug Something isn't working label Mar 3, 2020
@damienroche
Copy link
Owner

Hi guys,
I can't reproduce this.
can you provide me a sandbox link please

@lornacodes
Copy link

My issue was more similar the second part of the first comment

"It should simply not show the future years but the right count of years in the past."

And this was the same for the months - you could still select future months in this view. I believe this is still an issue on your demo here where you shouldn't be able to select past years/months?

@damienroche
Copy link
Owner

oh ok now I understand. I will look deeper at this

damienroche added a commit that referenced this issue Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants