Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project ground work #1

Merged
merged 11 commits into from Jul 24, 2016
Merged

Project ground work #1

merged 11 commits into from Jul 24, 2016

Conversation

pleb
Copy link
Collaborator

@pleb pleb commented Jul 23, 2016

@nick2170

Can you please review this PR for me thanks?

The PR includes ground work that we've spoke about previously.

It'll be a combination item with this wiki page developer environment setup, which is still a work-in-progress item.

In summary:

  • Adds code style guide
  • Adds code formatting
  • Adds npm script to format whole solution
  • Adds code hinting
  • Updates project so it will build and run
  • Inc other minor items

@damoclark
Copy link
Owner

Looks good to me Wade.

If its all good with @nick2170 then merge with dev.

Before you do though, can you update the PR by adding both your names to the authorship in the package.json file.

D.

@nick2170
Copy link
Collaborator

Looks good.

On 24 Jul 2016 11:47, "Damo" notifications@github.com wrote:

Looks good to me Wade.

If its all good with @nick2170 https://github.com/nick2170 then merge
with dev.

Before you do though, can you update the PR by adding both your names to
the authorship in the package.json file.

D.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATgjMWNYlyixJ-K1f0BVJ1ZtASxnXvkeks5qYsQQgaJpZM4JTSew
.

@pleb
Copy link
Collaborator Author

pleb commented Jul 24, 2016

Updated wiki link, as it was broken 😮

@pleb pleb merged commit c2a46b7 into dev Jul 24, 2016
@pleb pleb deleted the ProjectGroundWork branch July 24, 2016 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants