Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to toggle modifiers #38

Merged
merged 4 commits into from
Feb 19, 2020
Merged

Allow users to toggle modifiers #38

merged 4 commits into from
Feb 19, 2020

Conversation

damonhook
Copy link
Owner

@damonhook damonhook commented Feb 18, 2020

Additions

  • Users can now toggle profile and target modifiers using a toggle switch.

@damonhook damonhook marked this pull request as ready for review February 19, 2020 12:28
@damonhook damonhook merged commit f74857c into rc-2.0.0 Feb 19, 2020
@damonhook damonhook deleted the modifier-toggle branch February 19, 2020 12:29
damonhook added a commit that referenced this pull request Feb 21, 2020
…ce improvements (#35)

## Additions

- Users can now toggle profile and target modifiers using a toggle switch (fixes #38).

## UI

- Remove Beta Tag from non beta features
- Small UI overhaul for Desktop (Mostly related to the drawer)
- Add Warcry Statshammer links and buttons (fixes: #23)
- Change SVG Text Object -> Path (fixes #25)
    - Use SVGIcon instead of loading through img src
- Make the Left navigation bar responsive based on the following criteria (fixes #34)
    - **Large:** Show the full drawer
    - **Medium**: Show a Rail but let users open the drawer
    - **Small:** Hide the rail, let users open the drawer
- Add an Average damage graph to the `Metrics` tab in the `Simulations` screen for easier reference

## API

- Use a calculated population max (The actual max) rather than basing it on the max value of the simulated sample (fixes: #30)
    - This has had the effect of vastly improving the accuracy of the simulated metrics.
    - Also use the population mean, rather than the sample mean
- Remove Median as the way the data is distributed, it is usually extremely close to mean anyway
- Calculate frequency table on the fly, rather than creating a large results array first (fixes #32)
- Completely refactor the response structure of the `/api/simulate` and `/api/simulate/save` endpoints for better visibility and extensibility.
- Added Sentry to API to capture errors (Fixes: #39)

## Notes

- This UI overhaul was more focused on navigation, the next one will be more about layout
- Though it may not look it, this release had a huge amount of behind the scenes changes
- Since the 2.0.0 branch, I have been using Github projects to greater effect, this means you can watch the project for a specific version to see the currently planned items, and their progress
    - [v2.0.0](https://github.com/damonhook/aos-statshammer/projects/1) This one
    - [v2.1.0](https://github.com/damonhook/aos-statshammer/projects/2) The next one
    - [v2.2.0](https://github.com/damonhook/aos-statshammer/projects/3) This one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant