Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

See highlighted segments on kind1 notes #1772

Open
Tracked by #2174
alltheseas opened this issue Nov 27, 2023 · 3 comments
Open
Tracked by #2174

See highlighted segments on kind1 notes #1772

alltheseas opened this issue Nov 27, 2023 · 3 comments
Assignees
Labels

Comments

@alltheseas
Copy link
Collaborator

alltheseas commented Nov 27, 2023

user story

As a Damus user who is seeking signal, I want to be able to see highlights of my WOT, so that I can find and read what others think provides the most signal.

acceptance criteria

  1. If someone in my WOT (can define as follows only, at least to start) highlights I note I see, or interact with I would like to see their highlight
  2. I can visually see who highlighted a note

@ericholguin has a PR on his branch

video in note below:

https://damus.io/note1sm6e6v4uz6mr6kth4faze8mlj54353lzzcy09qt552ytatxj38kq8l7cnc

https://njump.me/note1sm6e6v4uz6mr6kth4faze8mlj54353lzzcy09qt552ytatxj38kq8l7cnc

implementation
NIP-84

related to

create highlights #822
see long form highlights #1773

@alltheseas
Copy link
Collaborator Author

alltheseas commented Nov 27, 2023

@jb55 - @ericholguin is asking if reading highlights on Damus is planned.

I support adding this feature - as we discussed today my view is that interoperability is the key to Damus, and nostr winning.

Three questions:

Are you onboard with see note highlights in Damus?
If @ericholguin contributes a patch, will you have capacity to review, and merge?
Do you agree on order of operations: see kind1 note highlights first, followed immediately by see long form note highlights?

@jb55
Copy link
Collaborator

jb55 commented Nov 27, 2023

I'm ok with it but when it gets to longform highlights it can get pretty complex pretty quickly. simple web highlights would be great.

@jb55 jb55 mentioned this issue Apr 19, 2024
6 tasks
@alltheseas alltheseas added the enhancement Improvement label Apr 19, 2024
@alltheseas
Copy link
Collaborator Author

alltheseas commented Apr 19, 2024

closed duplicate here: #2110

updated user story

@alltheseas alltheseas mentioned this issue May 7, 2024
15 tasks
ericholguin added a commit to ericholguin/damus that referenced this issue May 27, 2024
This patch adds highlights (NIP-84) to Damus.

Kind 9802 are handled by all the necessary models.
We show highlighted events, longform events, and url references.
Url references also leverage text fragments to take the user to the highlighted text.

Testing
——
iPhone 15 Pro Max (17.0) Dark Mode:
https://v.nostr.build/oM6DW.mp4

iPhone 15 Pro Max (17.0) Light Mode:
https://v.nostr.build/BRrmP.mp4

iPhone SE (3rd generation) (16.4) Light Mode:
https://v.nostr.build/6GzKa.mp4
——

Closes: damus-io#2172
Closes: damus-io#1772
Closes: damus-io#1773
Closes: damus-io#2173
Closes: damus-io#2175
Changelog-Added: Highlights (NIP-84)

PATCH CHANGELOG:
V1 -> V2: addressed review comments highlights are now truncated and highlight label shown in Thread view

Signed-off-by: ericholguin <ericholguin@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Review
Development

No branches or pull requests

3 participants