-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Word muting is broken #2159
Comments
Tested this and it is 100% broken on my end as well. Will mentioned we might want to add this to 1.8. I agree with that idea, so I added this to the 1.8 milestone for now (given the feature is 100% broken) @alltheseas @jb55, do you have any objections to this? |
nope! |
agree |
see #1880 |
see #1934 |
See issues with mute label https://github.com/damus-io/damus/issues?q=is%3Aopen+is%3Aissue+label%3Amute |
see potential mute list hang/performance issue #2146 |
Sent a basic fix draft: https://groups.google.com/a/damus.io/g/patches/c/hfDnKV3eLGo @alltheseas @jb55, I was not 100% thorough with the above to give us flexibility to refine only as much as we need or as much as time allows us. Please advise how much refinement you'd like! |
Basic fix is a yuge update, thanks Daniel. Is temp muting excluded from 1.8 as we have not verified it works? |
Not necessarily excluded (it could be working), I am just not familiar with it yet and I haven't tested if my changes break it (or if it was working before) I think I should test it if we have time |
I have not been able to get word mutes working with the new mute overhaul.
Let's make sure we add tests!
The text was updated successfully, but these errors were encountered: