Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Word muting is broken #2159

Closed
Tracked by #2222 ...
jb55 opened this issue Apr 17, 2024 · 10 comments
Closed
Tracked by #2222 ...

Word muting is broken #2159

jb55 opened this issue Apr 17, 2024 · 10 comments
Assignees
Labels
bug Something is not working, or not working as intended mute Needs recreation Issues requires concrete steps for recreation

Comments

@jb55
Copy link
Collaborator

jb55 commented Apr 17, 2024

I have not been able to get word mutes working with the new mute overhaul.

Let's make sure we add tests!

@jb55 jb55 added bug Something is not working, or not working as intended Needs recreation Issues requires concrete steps for recreation labels Apr 17, 2024
@jb55 jb55 changed the title Mutes: word muting is broken Word muting is broken Apr 19, 2024
@danieldaquino
Copy link
Contributor

Tested this and it is 100% broken on my end as well.

Will mentioned we might want to add this to 1.8. I agree with that idea, so I added this to the 1.8 milestone for now (given the feature is 100% broken)

@alltheseas @jb55, do you have any objections to this?

@jb55
Copy link
Collaborator Author

jb55 commented May 6, 2024

nope!

@alltheseas
Copy link
Collaborator

agree

@alltheseas
Copy link
Collaborator

see #1880

@alltheseas
Copy link
Collaborator

see #1934

@alltheseas
Copy link
Collaborator

See issues with mute label https://github.com/damus-io/damus/issues?q=is%3Aopen+is%3Aissue+label%3Amute

@alltheseas
Copy link
Collaborator

see potential mute list hang/performance issue #2146

@danieldaquino
Copy link
Contributor

Sent a basic fix draft: https://groups.google.com/a/damus.io/g/patches/c/hfDnKV3eLGo

@alltheseas @jb55, I was not 100% thorough with the above to give us flexibility to refine only as much as we need or as much as time allows us. Please advise how much refinement you'd like!

@alltheseas
Copy link
Collaborator

Sent a basic fix draft: https://groups.google.com/a/damus.io/g/patches/c/hfDnKV3eLGo

@alltheseas @jb55, I was not 100% thorough with the above to give us flexibility to refine only as much as we need or as much as time allows us. Please advise how much refinement you'd like!

Basic fix is a yuge update, thanks Daniel. Is temp muting excluded from 1.8 as we have not verified it works?

@danieldaquino
Copy link
Contributor

Is temp muting excluded from 1.8 as we have not verified it works?

Not necessarily excluded (it could be working), I am just not familiar with it yet and I haven't tested if my changes break it (or if it was working before)

I think I should test it if we have time

@jb55 jb55 closed this as completed May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working, or not working as intended mute Needs recreation Issues requires concrete steps for recreation
Projects
Status: Live
Development

No branches or pull requests

3 participants