Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont show me muted re-posts #1934

Open
alltheseas opened this issue Jan 28, 2024 · 4 comments
Open

Dont show me muted re-posts #1934

alltheseas opened this issue Jan 28, 2024 · 4 comments
Assignees
Labels

Comments

@alltheseas
Copy link
Collaborator

image

@alltheseas
Copy link
Collaborator Author

image

@danieldaquino
Copy link
Contributor

@alltheseas I will try working on this one next, as I am familiar with that area of the codebase and have a good idea on how to fix it.

Please let me know if there is something else that is more important to work on. Thanks!

@alltheseas
Copy link
Collaborator Author

Sounds good Daniel, thanks for troubleshooting my large contact list earlier. This one seems perfect as you are familiar with the code, and it is the end of the day.

On the topic of muting, best guess that what caused me to lag before my mute list was wiped was a large mute list: #2146.

Outside of this topic, I've pushed the top 10 or so what I think to be the more important issues to the top of the 1.9 milestone list: https://github.com/damus-io/damus/milestone/14. We can discuss Monday.

Thank you again.

@danieldaquino
Copy link
Contributor

Sent fix! https://groups.google.com/a/damus.io/g/patches/c/GIZhMSWPLFo

@jb55 please let me know if you have any questions or suggestions.

Thank you!

danieldaquino added a commit that referenced this issue May 25, 2024
Testing
--------

PASS

Device: iPhone 15 simulator
iOS: 17.4
Damus: This commit
Steps:
1. Mute a specific user "A" from account "B"
2. Make account "B" follow account "C"
3. Using a separate account "C", repost a note from account "A"
4. Make sure that the reposted note from step 3 does not appear on account "B"'s timeline
5. Make sure other reposts of other users still show normally

Other testing: Ran all automated tests, and they are passing.

Closes: #1934
Changelog-Changed: Do not show reposts of muted events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Review
Development

No branches or pull requests

2 participants