Enable Private Relays [500,000 sats] NIP-42

[alltheseas]

User Story

As a Damus user who wants to connect with a particular group of nostriches privately, I want to be able to connect to a private relay, so that I can read and share notes only with a specific group of nostriches.

Acceptance Criteria

1. Damus user can connect to a private relay
2. Damus user has a method to provide authentication details to a private relay
3. Damus user can check visually if they are successfully connected to the private relay
4. Damus user can remove a private relay
5. Damus user can de-authenticate from a private relay

implementation details
NIP-42

relates to
#453

Origin: https://damus.io/note1c6khgk6phxzhq7hh2v32nhzrvlyn4y2ctk6h0kgtgfrgrh7y7e5qma8ykl

[nostr-wine]

We'll offer a 500k sats bounty per client for this feature.

[LouisLibre]

Is there a private relay where we can test out the implementation?

[nostr-wine]

Yes! You can use wss://filter.nostr.wine or wss://nostr.kollider.xyz

[nostr-wine]

Any takers?

[jb55]

I’ll do this soon

[nostr-wine]

Thanks Will! Much appreciated.

[fishcharlie]

@jb55 You mentioned that you'll do this soon a while back. Are you working on this?

If not, I'd love to take a shot at contributing and trying to implement this. I'll keep everyone updated on my progress here.

But I don't wanna step on your toes @jb55 if you're already working on it.

[alltheseas]

Go for it @fishcharlie

[fishcharlie]

Awesome. I'll start looking into this this evening and hopefully will have something sometime this week to show.

[fishcharlie]

https://groups.google.com/a/damus.io/g/patches/c/NIDfecrJN_g

[jb55]

it looks pretty good! I just need a way to test it.

[nostr-wine]

If you're looking for relays, here are two different AUTH flows:

wss://filter.nostr.wine - AUTH on connect, only allows paid pubkeys are accepted
wss://nostr.wine - AUTH on kind 4 REQs, allows all pubkeys

[jb55]

@fishcharlie maybe we could have some tests for these relays?

[fishcharlie]

@jb55 Open to that idea. My question would be does Damus have any tests currently that depend on 3rd party relays? Not saying that @nostr-wine won't survive for a long time to come. But that is a pretty major dependency that we'd be introducing to the Damus test suite.

It might be better to just mock the requests and replies. But I'm open to creating a connection to those relays if you want.

[fishcharlie]

For the time being I'm currently working on writing a test that verifies that based on the objects that the correct message is generated.

Similar to RequestTests.swift testMakeUnsubscribeRequest (but for the auth).

[jb55]

On Thu, Dec 21, 2023 at 06:05:17PM -0800, Charlie Fish wrote: @jb55 Open to that idea. My question would be does Damus have any tests currently that depend on 3rd party relays? Not saying that @nostr-wine won't survive for a long time to come. But that is a pretty major dependency that we'd be introducing to the Damus test suite.

I'm not against network tests. we had one for nostrscript at one point They tend to be flaky, but it would be nice to see it working against a non-mocked target for the first release.

[fishcharlie]

@jb55 Sounds good. I'll work on that and let you know when I have an update.

[fishcharlie]

@jb55 Added some tests: https://groups.google.com/a/damus.io/g/patches/c/Zx3dk01e0yg. Also added NIP-42 to the README since I forgot to do that originally.

Let me know what you think 😃

[jb55]

bounties can be paid to: fishcharlie@strike.me

@nostr-wine

[nostr-wine]

Paid! Awesome work @fishcharlie, thanks for merging @jb55.

[fishcharlie]

Thank you @nostr-wine! 🎉