Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nostrdb, switch to local relay model #2121

Draft
wants to merge 116 commits into
base: master
Choose a base branch
from

wip local relay model

c476272
Select commit
Loading
Failed to load commit list.
Draft

Update nostrdb, switch to local relay model #2121

wip local relay model
c476272
Select commit
Loading
Failed to load commit list.
Xcode Cloud / damus | Default | Test - iOS required action Apr 25, 2024 in 4m 57s

1 error, 151 warnings

Report Summary
Errors 1
Test Failures 0
Analysis Issues 0
Warnings 151

Details

1 Error

Details

  damusTests/Util/NdbExtensions.swift:24
      Cannot force unwrap value of non-optional type 'Ndb'

151 Warnings

Details

  nostrdb/src/nostrdb.c:349
      Implicit conversion loses integer precision: 'ssize_t' (aka 'long') to 'int'
  nostrdb/src/protected_queue.h:124
      Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int'
  nostrdb/src/nostrdb.c:2998
      Implicit conversion loses integer precision: 'uint64_t' (aka 'unsigned long long') to 'int'
  nostrdb/mdb.c:5753
      Implicit conversion loses integer precision: 'MDB_ID' (aka 'unsigned long') to 'unsigned int'
  nostrdb/src/nostrdb.c:643
      Implicit conversion loses integer precision: 'uint64_t' (aka 'unsigned long long') to 'int'
  nostrdb/src/nostrdb.c:5039
      Implicit conversion loses integer precision: 'long' to 'int'
  nostrdb/mdb.c:3579
      Implicit conversion loses integer precision: 'MDB_ID' (aka 'unsigned long') to 'unsigned int'
  nostrdb/mdb.c:5271
      Implicit conversion loses integer precision: 'const size_t' (aka 'const unsigned long') to 'unsigned int'
  nostrdb/src/cursor.h:702
      Unused function 'consume_whitespace_or_punctuation'
  nostrdb/src/nostrdb.c:2086
      Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int'
  nostrdb/src/nostrdb.c:5025
      Implicit conversion loses integer precision: 'long' to 'int'
  nostrdb/src/nostrdb.c:4791
      Implicit conversion loses integer precision: 'long' to 'int'
  nostrdb/Ndb.swift:204
      Initialization of immutable value 'ctx' was never used; consider replacing with assignment to '_' or removing it
  nostrdb/mdb.c:3329
      Implicit conversion loses integer precision: 'MDB_ID' (aka 'unsigned long') to 'int'
  nostrdb/mdb.c:3597
      Implicit conversion loses integer precision: 'MDB_ID' (aka 'unsigned long') to 'unsigned int'
  nostrdb/src/nostrdb.c:5603
      Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int'
  nostrdb/src/nostrdb.c:5017
      Implicit conversion loses integer precision: 'long' to 'uint32_t' (aka 'unsigned int')
  nostrdb/mdb.c:5279
      Implicit conversion loses integer precision: 'ssize_t' (aka 'long') to 'int'
  nostrdb/mdb.c:3903
      Implicit conversion loses integer precision: 'unsigned long long' to 'int'
  nostrdb/src/nostrdb.c:3007
      Implicit conversion loses integer precision: 'uint64_t' (aka 'unsigned long long') to 'int'
  nostrdb/mdb.c:2287
      Implicit conversion loses integer precision: 'pgno_t' (aka 'unsigned long') to 'unsigned int'
  nostrdb/src/nostrdb.c:730
      Implicit conversion loses integer precision: 'long' to 'int'
  nostrdb/mdb.c:4733
      '@param' command used in a comment that is not attached to a function declaration
  damus/ContentView.swift:995
      Variable 'nostrKinds' was never mutated; consider changing to 'let' constant
  nostrdb/src/nostrdb.c:4868
      Implicit conversion loses integer precision: 'long' to 'uint32_t' (aka 'unsigned int')
  damus/ContentView.swift:546
      Immutable value 'naddr' was never used; consider replacing with '_' or removing it
  nostrdb/mdb.c:4212
      Implicit conversion loses integer precision: 'unsigned long' to 'int'
  damus/Views/NoteContentView.swift:35
      'withUnsafeBytes' is deprecated: use `withUnsafeBytes(_: (UnsafeRawBufferPointer) throws -> R) rethrows -> R` instead
  nostrdb/mdb.c:7357
      Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int'
  nostrdb/Ndb.swift:420
      Backward matching of the unlabeled trailing closure is deprecated; label the argument with 'with' to suppress this warning
  nostrdb/mdb.c:2193
      Implicit conversion loses integer precision: 'pgno_t' (aka 'unsigned long') to 'unsigned int'
  nostrdb/src/nostrdb.c:4246
      Implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'int'
  nostrdb/src/content_parser.c:580
      Implicit conversion loses integer precision: 'long' to 'uint32_t' (aka 'unsigned int')
  nostrdb/src/nostrdb.c:5838
      Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int'
  nostrdb/src/content_parser.c:84
      Implicit conversion loses integer precision: 'long' to 'uint32_t' (aka 'unsigned int')
  nostrdb/src/nostrdb.c:2087
      Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int'
  damus/Models/EventRef.swift:103
      Variable 'mentions' was never mutated; consider changing to 'let' constant
  nostrdb/mdb.c:2607
      '@return' command used in a comment that is attached to a function returning void
  nostrdb/src/nostrdb.c:649
      Implicit conversion loses integer precision: 'uint64_t' (aka 'unsigned long long') to 'int'
  nostrdb/mdb.c:2923
      Implicit conversion loses integer precision: 'pgno_t' (aka 'unsigned long') to 'int'
  nostrdb/src/nostrdb.c:4812
      Implicit conversion loses integer precision: 'long' to 'int'
  damus/Models/HomeModel.swift:388
      Immutable value 'n' was never used; consider replacing with '_' or removing it
  nostrdb/src/content_parser.c:476
      Implicit conversion loses integer precision: 'long' to 'uint32_t' (aka 'unsigned int')
  nostrdb/mdb.c:5773
      Implicit conversion loses integer precision: 'pgno_t' (aka 'unsigned long') to 'unsigned int'
  nostrdb/src/sha256.h:40
      '@p' command has no word arguments, expected 1
  nostrdb/src/nostrdb.c:1434
      Unused function 'ndb_tsid_low'
  nostrdb/src/nostrdb.c:4486
      Implicit conversion loses integer precision: 'long' to 'uint32_t' (aka 'unsigned int')
  nostrdb/mdb.c:7070
      Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int'
  nostrdb/mdb.c:2251
      Code will never be executed
  nostrdb/mdb.c:8772
      Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int'
  nostrdb/src/nostrdb.c:3516
      Variable 'saved_size' may be uninitialized when used here
  nostrdb/src/nostrdb.c:5645
      Implicit conversion loses integer precision: 'unsigned long' to 'int'
  damus/Models/ThreadModel.swift:89
      Converting function value of type '@MainActor (RelayURL, NostrConnectionEvent) -> ()' to '(RelayURL, NostrConnectionEvent) -> ()' loses global actor 'MainActor'; this is an error in Swift 6
  nostrdb/mdb.c:3539
      Implicit conversion loses integer precision: 'MDB_ID' (aka 'unsigned long') to 'unsigned int'
  nostrdb/src/nostrdb.c:450
      Implicit conversion loses integer precision: 'uint64_t' (aka 'unsigned long long') to 'int'
  nostrdb/mdb.c:6814
      Implicit conversion loses integer precision: 'unsigned long' to 'unsigned int'
  nostrdb/src/content_parser.c:443
      Implicit conversion loses integer precision: 'long' to 'uint32_t' (aka 'unsigned int')
  damus/Views/SearchResultsView.swift:211
      Initialization of immutable value 'new' was never used; consider replacing with assignment to '_' or removing it
  nostrdb/src/nostrdb.c:341
      Implicit conversion loses integer precision: 'const size_t' (aka 'const unsigned long') to 'unsigned int'
  damus/Models/ZapsModel.swift:34
      Converting function value of type '@MainActor (RelayURL, NostrConnectionEvent) -> ()' to '(RelayURL, NostrConnectionEvent) -> ()' loses global actor 'MainActor'; this is an error in Swift 6
  nostrdb/mdb.c:3543
      Implicit conversion loses integer precision: 'MDB_ID' (aka 'unsigned long') to 'unsigned int'
  nostrdb/mdb.c:7825
      Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int'
  damus/Util/Zap.swift:407
      Immutable value 'deschash' was never used; consider replacing with '_' or removing it
  nostrdb/src/content_parser.c:201
      Implicit conversion loses integer precision: 'long' to 'uint32_t' (aka 'unsigned int')
  nostrdb/src/content_parser.c:498
      Implicit conversion loses integer precision: 'long' to 'uint32_t' (aka 'unsigned int')
  nostrdb/src/content_parser.c:588
      Implicit conversion loses integer precision: 'long' to 'uint32_t' (aka 'unsigned int')
  nostrdb/midl.c:177
      Implicit conversion loses integer precision: 'MDB_ID' (aka 'unsigned long') to 'int'
  nostrdb/src/cursor.h:420
      Implicit conversion loses integer precision: 'uint64_t' (aka 'unsigned long long') to 'int'
  nostrdb/src/protected_queue.h:197
      Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int'
  nostrdb/src/nostrdb.c:3003
      Implicit conversion loses integer precision: 'uint64_t' (aka 'unsigned long long') to 'int'
  nostrdb/src/nostrdb.c:4725
      Implicit conversion loses integer precision: 'long' to 'int'
  nostrdb/src/nostrdb.c:344
      Implicit conversion loses integer precision: 'const size_t' (aka 'const unsigned long') to 'unsigned int'
  damus/Models/EventRef.swift:66
      Immutable value 'idx' was never used; consider replacing with '_' or removing it
  nostrdb/mdb.c:6858
      Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'unsigned int'
  nostrdb/mdb.c:6599
      Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'unsigned int'
  file:///Volumes/workspace/DerivedData/Build/Intermediates.noindex/damus.build/Debug-iphonesimulator/damus.build/DerivedSources/GeneratedAssetSymbols.swift:6735
      The "checkmark" image asset name resolves to a conflicting UIImage symbol "checkmark". Try renaming the asset.
  nostrdb/mdb.c:3582
      Implicit conversion loses integer precision: 'MDB_ID' (aka 'unsigned long') to 'unsigned int'
  damus/Views/Onboarding/SuggestedUserView.swift:60
      Initialization of immutable value 'profile' was never used; consider replacing with assignment to '_' or removing it
  nostrdb/mdb.c:5274
      Implicit conversion loses integer precision: 'const size_t' (aka 'const unsigned long') to 'unsigned int'
  nostrdb/src/nostrdb.c:1389
      Implicit conversion loses integer precision: 'uint64_t' (aka 'unsigned long long') to 'int'
  nostrdb/mdb.c:6894
      Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int'
  nostrdb/src/nostrdb.c:5044
      Implicit conversion loses integer precision: 'long' to 'int'
  nostrdb/src/nostrdb.c:296
      Implicit conversion loses integer precision: 'long' to 'int'
  damus/Views/NoteContentView.swift:27
      'withUnsafeBytes' is deprecated: use `withUnsafeBytes(_: (UnsafeRawBufferPointer) throws -> R) rethrows -> R` instead
  nostrdb/src/nostrdb.c:4529
      Implicit conversion loses integer precision: 'unsigned long' to 'int'
  nostrdb/src/protected_queue.h:167
      Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int'
  nostrdb/src/nostrdb.c:4847
      Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int'
  damus/Util/Zap.swift:411
      Value 'data' was defined but never used; consider replacing with boolean test
  nostrdb/src/nostrdb.c:3185
      Implicit conversion loses integer precision: 'long' to 'int'
  nostrdb/mdb.c:3920
      Implicit conversion loses integer precision: 'ssize_t' (aka 'long') to 'int'
  nostrdb/flatcc/builder.c:1143
      Code will never be executed
  nostrdb/src/nostrdb.c:416
      Variable 'nid_b' may be uninitialized when used here
  nostrdb/src/content_parser.c:450
      Implicit conversion loses integer precision: 'long' to 'uint32_t' (aka 'unsigned int')
  damus/ContentView.swift:532
      Value 'damus_state' was defined but never used; consider replacing with boolean test
  nostrdb/mdb.c:4732
      '@param' command used in a comment that is not attached to a function declaration
  nostrdb/src/sha256.h:122
      '@p' command has no word arguments, expected 1
  nostrdb/src/nostrdb.c:5670
      Implicit conversion loses integer precision: 'uint64_t' (aka 'unsigned long long') to 'uint32_t' (aka 'unsigned int')
  damus/Models/Post.swift:43
      'withUnsafeMutableBytes' is deprecated: use `withUnsafeMutableBytes(_: (UnsafeMutableRawBufferPointer) throws -> R) rethrows -> R` instead
  nostrdb/mdb.c:5305
      Implicit conversion loses integer precision: 'ssize_t' (aka 'long') to 'int'
  nostrdb/src/protected_queue.h:91
      Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int'
  nostrdb/mdb.c:9142
      Implicit conversion loses integer precision: 'ssize_t' (aka 'long') to 'int'
  nostrdb/mdb.c:1860
      Implicit conversion loses integer precision: 'MDB_ID' (aka 'unsigned long') to 'unsigned int'
  damus/Models/MuteItem.swift:52
      Immutable value 'rhs_expiration_date' was never used; consider replacing with '_' or removing it
  damus/Models/MuteItem.swift:50
      Immutable value 'rhs_expiration_date' was never used; consider replacing with '_' or removing it
  nostrdb/src/nostrdb.c:1636
      Unused function 'ndb_writer_queue_note'
  nostrdb/src/nostrdb.c:4465
      Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int'
  nostrdb/mdb.c:3728
      Implicit conversion loses integer precision: 'ssize_t' (aka 'long') to 'int'
  nostrdb/src/nostrdb.c:4405
      Implicit conversion loses integer precision: 'long' to 'int'
  nostrdb/midl.c:44
      Implicit conversion loses integer precision: 'MDB_ID' (aka 'unsigned long') to 'unsigned int'
  damus/Models/DamusState.swift:107
      Initialization of immutable value 'kp' was never used; consider replacing with assignment to '_' or removing it
  nostrdb/mdb.c:7979
      Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int'
  nostrdb/src/cursor.h:717
      Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int'
  nostrdb/src/nostrdb.c:3015
      Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int'
  nostrdb/src/nostrdb.c:399
      Variable 'sb' may be uninitialized when used here
  nostrdb/src/print_util.h:18
      Unused function 'ndb_print_text_search_result'
  DamusNotificationService/NotificationExtensionState.swift:21
      No calls to throwing functions occur within 'try' expression
  nostrdb/src/cursor.h:407
      Implicit conversion loses integer precision: 'uint64_t' (aka 'unsigned long long') to 'int'
  damus/Models/MuteItem.swift:54
      Immutable value 'rhs_expiration_date' was never used; consider replacing with '_' or removing it
  nostrdb/Ndb.swift:414
      Backward matching of the unlabeled trailing closure is deprecated; label the argument with 'with' to suppress this warning
  nostrdb/src/nostrdb.c:4625
      Implicit conversion loses integer precision: 'unsigned long' to 'int'
  nostrdb/src/nostrdb.c:4431
      Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int'
  nostrdb/mdb.c:5761
      Implicit conversion loses integer precision: 'MDB_ID' (aka 'unsigned long') to 'unsigned int'
  damus/Models/MuteItem.swift:56
      Immutable value 'rhs_expiration_date' was never used; consider replacing with '_' or removing it
  nostrdb/src/cpu.h:13
      A function declaration without a prototype is deprecated in all versions of C
  nostrdb/src/block.c:31
      Implicit conversion loses integer precision: 'uint64_t' (aka 'unsigned long long') to 'enum nostr_bech32_type'
  nostrdb/mdb.c:2057
      Implicit conversion loses integer precision: 'MDB_ID' (aka 'unsigned long') to 'unsigned int'
  nostrdb/mdb.c:2922
      Implicit conversion loses integer precision: 'unsigned long' to 'int'
  damus/Models/ThreadModel.swift:97
      Result of call to 'upsert' is unused
  nostrdb/mdb.c:5774
      Implicit conversion loses integer precision: 'pgno_t' (aka 'unsigned long') to 'unsigned int'
  nostrdb/src/nostrdb.c:2814
      Implicit conversion loses integer precision: 'unsigned long' to 'int'
  nostrdb/src/cursor.h:324
      Unused function 'cursor_pull_varint_u32'
  damus/Views/Search/PullDownSearch.swift:22
      Variable 'note_keys' was never mutated; consider changing to 'let' constant
  nostrdb/mdb.c:2254
      Variable 'last' may be uninitialized when used here
  nostrdb/src/nostrdb.c:2992
      Implicit conversion loses integer precision: 'uint64_t' (aka 'unsigned long long') to 'int'
  flatbuffers/ByteBuffer.swift:237
      Forming 'UnsafeRawPointer' to a variable of type 'T'; this is likely incorrect because 'T' may contain an object reference.
  nostrdb/src/nostrdb.c:3593
      Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int'
  nostrdb/mdb.c:8770
      Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int'
  nostrdb/src/nostrdb.c:3648
      Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int'
  damus/Models/ThreadModel.swift:88
      Converting function value of type '@MainActor (RelayURL, NostrConnectionEvent) -> ()' to '(RelayURL, NostrConnectionEvent) -> ()' loses global actor 'MainActor'; this is an error in Swift 6
  flatbuffers/ByteBuffer.swift:250
      Forming 'UnsafeRawPointer' to a variable of type 'T'; this is likely incorrect because 'T' may contain an object reference.
  nostrdb/src/nostrdb.c:4797
      Implicit conversion loses integer precision: 'long' to 'uint32_t' (aka 'unsigned int')
  nostrdb/mdb.c:2082
      Implicit conversion loses integer precision: 'MDB_ID' (aka 'unsigned long') to 'unsigned int'
  nostrdb/mdb.c:2307
      Implicit conversion loses integer precision: 'pgno_t' (aka 'unsigned long') to 'unsigned int'
  damus/Models/HomeModel.swift:379
      Immutable value 'n' was never used; consider replacing with '_' or removing it
  nostrdb/mdb.c:3940
      Implicit conversion loses integer precision: 'ssize_t' (aka 'long') to 'int'
  nostrdb/mdb.c:4824
      Implicit conversion loses integer precision: 'unsigned long long' to 'unsigned int'
  nostrdb/src/nostrdb.c:2710
      Implicit conversion loses integer precision: 'long' to 'int'
  nostrdb/mdb.c:3992
      Implicit conversion loses integer precision: 'long' to 'unsigned int'
  nostrdb/src/nostrdb.c:4466
      Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int'
  nostrdb/mdb.c:3821
      Implicit conversion loses integer precision: 'ssize_t' (aka 'long') to 'int'
  nostrdb/src/nostrdb.c:4789
      Implicit conversion loses integer precision: 'long' to 'int'