Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore chatroom view (wip) #2179

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

restore chatroom view (wip)

0c8c984
Select commit
Loading
Failed to load commit list.
Draft

restore chatroom view (wip) #2179

restore chatroom view (wip)
0c8c984
Select commit
Loading
Failed to load commit list.
Xcode Cloud / damus | Default | Test - iOS required action Apr 25, 2024 in 8m 23s

6 test failures, 79 warnings

Report Summary
Errors 0
Test Failures 6
Analysis Issues 0
Warnings 79

Details

6 Test Failures

Details

  ReplyTests.testThreadedReply() | damusTests/ReplyTests.swift:157
      XCTAssertEqual failed: ("nil") is not equal to ("Optional(80093e9bdb495728f54cda2bad4aed096877189552b3d41264e73b9a9595be22)")
  ReplyTests.testThreadedReply() | damusTests/ReplyTests.swift:155
      XCTAssertEqual failed: ("nil") is not equal to ("Optional(da256fb52146dc565c6c6b9ef906117c665864dc02b14a7b853eca244729c2f2)")
  VideoCacheTests.testCachedURLForExistingVideo() | damusTests/VideoCacheTests.swift:51
      Asynchronous wait failed: Exceeded timeout of 8 seconds, with unfulfilled expectations: "On second time we get a video, the cached URL should be returned".
  ReplyTests.testThreadedReply() | damusTests/ReplyTests.swift:158
      XCTAssertNil failed: "80093e9bdb495728f54cda2bad4aed096877189552b3d41264e73b9a9595be22"
  VideoCacheTests.testClearCache() | damusTests/VideoCacheTests.swift:100
      Asynchronous wait failed: Exceeded timeout of 8 seconds, with unfulfilled expectations: "On second time we get a video, the cached URL should be returned".
  ReplyTests.testThreadedReply() | damusTests/ReplyTests.swift:156
      XCTAssertEqual failed: ("nil") is not equal to ("Optional(80093e9bdb495728f54cda2bad4aed096877189552b3d41264e73b9a9595be22)")

79 Warnings

Details

  damus/Views/SearchResultsView.swift:211
      Initialization of immutable value 'new' was never used; consider replacing with assignment to '_' or removing it
  nostrdb/midl.c:44
      Implicit conversion loses integer precision: 'MDB_ID' (aka 'unsigned long') to 'unsigned int'
  nostrdb/mdb.c:2287
      Implicit conversion loses integer precision: 'pgno_t' (aka 'unsigned long') to 'unsigned int'
  damus/Models/DamusState.swift:107
      Initialization of immutable value 'kp' was never used; consider replacing with assignment to '_' or removing it
  nostrdb/Ndb.swift:382
      Backward matching of the unlabeled trailing closure is deprecated; label the argument with 'with' to suppress this warning
  damusTests/damusTests.swift:24
      Initialization of immutable value 'ev' was never used; consider replacing with assignment to '_' or removing it
  damus-c/list.h:129
      'LIST_HEAD' macro redefined
  nostrdb/mdb.c:4733
      '@param' command used in a comment that is not attached to a function declaration
  nostrdb/mdb.c:4732
      '@param' command used in a comment that is not attached to a function declaration
  damus/Models/HomeModel.swift:388
      Immutable value 'n' was never used; consider replacing with '_' or removing it
  nostrdb/mdb.c:3903
      Implicit conversion loses integer precision: 'unsigned long long' to 'int'
  nostrdb/flatcc/builder.c:1143
      Code will never be executed
  damus/Models/ZapsModel.swift:34
      Converting function value of type '@MainActor (RelayURL, NostrConnectionEvent) -> ()' to '(RelayURL, NostrConnectionEvent) -> ()' loses global actor 'MainActor'; this is an error in Swift 6
  damus/ContentView.swift:533
      Value 'damus_state' was defined but never used; consider replacing with boolean test
  nostrdb/mdb.c:4824
      Implicit conversion loses integer precision: 'unsigned long long' to 'unsigned int'
  nostrdb/mdb.c:3582
      Implicit conversion loses integer precision: 'MDB_ID' (aka 'unsigned long') to 'unsigned int'
  damus/Models/MuteItem.swift:56
      Immutable value 'rhs_expiration_date' was never used; consider replacing with '_' or removing it
  nostrdb/mdb.c:8770
      Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int'
  nostrdb/mdb.c:3821
      Implicit conversion loses integer precision: 'ssize_t' (aka 'long') to 'int'
  nostrdb/mdb.c:2254
      Variable 'last' may be uninitialized when used here
  flatbuffers/ByteBuffer.swift:250
      Forming 'UnsafeRawPointer' to a variable of type 'T'; this is likely incorrect because 'T' may contain an object reference.
  nostrdb/mdb.c:6814
      Implicit conversion loses integer precision: 'unsigned long' to 'unsigned int'
  damus/Util/Zap.swift:407
      Immutable value 'deschash' was never used; consider replacing with '_' or removing it
  nostrdb/mdb.c:3597
      Implicit conversion loses integer precision: 'MDB_ID' (aka 'unsigned long') to 'unsigned int'
  nostrdb/mdb.c:9142
      Implicit conversion loses integer precision: 'ssize_t' (aka 'long') to 'int'
  damus/Models/ThreadModel.swift:99
      Converting function value of type '@MainActor (RelayURL, NostrConnectionEvent) -> ()' to '(RelayURL, NostrConnectionEvent) -> ()' loses global actor 'MainActor'; this is an error in Swift 6
  nostrdb/mdb.c:7825
      Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int'
  nostrdb/mdb.c:5271
      Implicit conversion loses integer precision: 'const size_t' (aka 'const unsigned long') to 'unsigned int'
  nostrdb/mdb.c:2307
      Implicit conversion loses integer precision: 'pgno_t' (aka 'unsigned long') to 'unsigned int'
  damus/ContentView.swift:547
      Immutable value 'naddr' was never used; consider replacing with '_' or removing it
  damus/ContentView.swift:989
      Variable 'nostrKinds' was never mutated; consider changing to 'let' constant
  nostrdb/mdb.c:3940
      Implicit conversion loses integer precision: 'ssize_t' (aka 'long') to 'int'
  damusTests/LongPostTests.swift:22
      Initialization of immutable value 'contacts' was never used; consider replacing with assignment to '_' or removing it
  nostrdb/mdb.c:4212
      Implicit conversion loses integer precision: 'unsigned long' to 'int'
  The CFBundleShortVersionString of an app extension ('1.8') must match that of its containing parent app ('1.9').
  nostrdb/mdb.c:2082
      Implicit conversion loses integer precision: 'MDB_ID' (aka 'unsigned long') to 'unsigned int'
  nostrdb/midl.c:177
      Implicit conversion loses integer precision: 'MDB_ID' (aka 'unsigned long') to 'int'
  nostrdb/mdb.c:3543
      Implicit conversion loses integer precision: 'MDB_ID' (aka 'unsigned long') to 'unsigned int'
  nostrdb/mdb.c:6858
      Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'unsigned int'
  damus/Models/HomeModel.swift:379
      Immutable value 'n' was never used; consider replacing with '_' or removing it
  nostrdb/mdb.c:5274
      Implicit conversion loses integer precision: 'const size_t' (aka 'const unsigned long') to 'unsigned int'
  nostrdb/mdb.c:7070
      Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int'
  nostrdb/mdb.c:7979
      Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int'
  nostrdb/mdb.c:2923
      Implicit conversion loses integer precision: 'pgno_t' (aka 'unsigned long') to 'int'
  nostrdb/mdb.c:5753
      Implicit conversion loses integer precision: 'MDB_ID' (aka 'unsigned long') to 'unsigned int'
  nostrdb/mdb.c:5761
      Implicit conversion loses integer precision: 'MDB_ID' (aka 'unsigned long') to 'unsigned int'
  nostrdb/Ndb.swift:376
      Backward matching of the unlabeled trailing closure is deprecated; label the argument with 'with' to suppress this warning
  nostrdb/mdb.c:7357
      Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int'
  nostrdb/mdb.c:2607
      '@return' command used in a comment that is attached to a function returning void
  damus/Models/MuteItem.swift:50
      Immutable value 'rhs_expiration_date' was never used; consider replacing with '_' or removing it
  DamusNotificationService/NotificationExtensionState.swift:21
      No calls to throwing functions occur within 'try' expression
  file:///Volumes/workspace/DerivedData/Build/Intermediates.noindex/damus.build/Debug-iphonesimulator/damus.build/DerivedSources/GeneratedAssetSymbols.swift:6735
      The "checkmark" image asset name resolves to a conflicting UIImage symbol "checkmark". Try renaming the asset.
  nostrdb/mdb.c:5305
      Implicit conversion loses integer precision: 'ssize_t' (aka 'long') to 'int'
  damus/Views/Search/PullDownSearch.swift:22
      Variable 'note_keys' was never mutated; consider changing to 'let' constant
  damus/Util/Zap.swift:411
      Value 'data' was defined but never used; consider replacing with boolean test
  nostrdb/mdb.c:5774
      Implicit conversion loses integer precision: 'pgno_t' (aka 'unsigned long') to 'unsigned int'
  nostrdb/mdb.c:3579
      Implicit conversion loses integer precision: 'MDB_ID' (aka 'unsigned long') to 'unsigned int'
  nostrdb/mdb.c:2251
      Code will never be executed
  nostrdb/mdb.c:2922
      Implicit conversion loses integer precision: 'unsigned long' to 'int'
  damus/Models/MuteItem.swift:52
      Immutable value 'rhs_expiration_date' was never used; consider replacing with '_' or removing it
  damus/Models/ThreadModel.swift:108
      Result of call to 'upsert' is unused
  nostrdb/mdb.c:2193
      Implicit conversion loses integer precision: 'pgno_t' (aka 'unsigned long') to 'unsigned int'
  nostrdb/mdb.c:3329
      Implicit conversion loses integer precision: 'MDB_ID' (aka 'unsigned long') to 'int'
  flatbuffers/ByteBuffer.swift:237
      Forming 'UnsafeRawPointer' to a variable of type 'T'; this is likely incorrect because 'T' may contain an object reference.
  nostrdb/mdb.c:6599
      Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'unsigned int'
  damus/Models/MuteItem.swift:54
      Immutable value 'rhs_expiration_date' was never used; consider replacing with '_' or removing it
  nostrdb/mdb.c:3992
      Implicit conversion loses integer precision: 'long' to 'unsigned int'
  damus/Views/Onboarding/SuggestedUserView.swift:60
      Initialization of immutable value 'profile' was never used; consider replacing with assignment to '_' or removing it
  nostrdb/mdb.c:5773
      Implicit conversion loses integer precision: 'pgno_t' (aka 'unsigned long') to 'unsigned int'
  nostrdb/mdb.c:3728
      Implicit conversion loses integer precision: 'ssize_t' (aka 'long') to 'int'
  nostrdb/mdb.c:6894
      Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int'
  nostrdb/mdb.c:2057
      Implicit conversion loses integer precision: 'MDB_ID' (aka 'unsigned long') to 'unsigned int'
  nostrdb/mdb.c:3920
      Implicit conversion loses integer precision: 'ssize_t' (aka 'long') to 'int'
  damus/Models/ThreadModel.swift:100
      Converting function value of type '@MainActor (RelayURL, NostrConnectionEvent) -> ()' to '(RelayURL, NostrConnectionEvent) -> ()' loses global actor 'MainActor'; this is an error in Swift 6
  nostrdb/mdb.c:1860
      Implicit conversion loses integer precision: 'MDB_ID' (aka 'unsigned long') to 'unsigned int'
  damusTests/NIP10Tests.swift:67
      Initialization of immutable value 'mention_id' was never used; consider replacing with assignment to '_' or removing it
  nostrdb/mdb.c:5279
      Implicit conversion loses integer precision: 'ssize_t' (aka 'long') to 'int'
  nostrdb/mdb.c:3539
      Implicit conversion loses integer precision: 'MDB_ID' (aka 'unsigned long') to 'unsigned int'
  nostrdb/mdb.c:8772
      Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int'