clipp: fix warnings

Signed-off-by: William Casarin <jb55@jb55.com>

shell.nix

@@ -1,7 +1,7 @@
 { pkgs ? import <nixpkgs> {} }:
 with pkgs;
 mkShell {
-  nativeBuildInputs = [ rustPlatform.bindgenHook cargo rustc rustfmt libiconv pkg-config valgrind ];
+  nativeBuildInputs = [ rustPlatform.bindgenHook cargo clippy rustc rustfmt libiconv pkg-config valgrind ];
 
   LIBCLANG_PATH="${pkgs.llvmPackages.libclang.lib}/lib";
 }

src/bindings.rs

@@ -1,3 +1,4 @@
+#![allow(clippy::all)]
 /* automatically generated by rust-bindgen 0.69.1 */
 
 #[repr(C)]

src/block.rs

@@ -170,7 +170,7 @@ impl<'a> Block<'a> {
                 return "";
             }
 
-            (&*str_block).as_str()
+            (*str_block).as_str()
         }
     }
 

src/config.rs

@@ -4,6 +4,12 @@ pub struct Config {
     pub config: bindings::ndb_config,
 }
 
+impl Default for Config {
+    fn default() -> Self {
+        Config::new()
+    }
+}
+
 impl Config {
     pub fn new() -> Self {
         let mut config = bindings::ndb_config {

src/filter.rs

@@ -67,6 +67,7 @@ impl Default for bindings::ndb_filter {
 }
 
 impl Filter {
+    #![allow(clippy::new_ret_no_self)]
     pub fn new() -> FilterBuilder {
         FilterBuilder {
             data: Default::default(),
@@ -81,11 +82,17 @@ impl Filter {
     }
 
     pub fn as_ptr(&self) -> *const bindings::ndb_filter {
-        return self.data.as_ptr();
+        self.data.as_ptr()
     }
 
     pub fn as_mut_ptr(&mut self) -> *mut bindings::ndb_filter {
-        return self.data.as_mut_ptr() as *mut bindings::ndb_filter;
+        self.data.as_mut_ptr()
+    }
+}
+
+impl Default for FilterBuilder {
+    fn default() -> Self {
+        FilterBuilder::new()
     }
 }
 
@@ -97,11 +104,11 @@ impl FilterBuilder {
     }
 
     pub fn as_ptr(&self) -> *const bindings::ndb_filter {
-        return self.data.as_ptr();
+        self.data.as_ptr()
     }
 
     pub fn as_mut_ptr(&mut self) -> *mut bindings::ndb_filter {
-        return self.data.as_mut_ptr();
+        self.data.as_mut_ptr()
     }
 
     fn add_int_element(&mut self, i: u64) {

src/ndb.rs

@@ -1,4 +1,3 @@
-use libc;
 use std::ffi::CString;
 use std::ptr;
 
@@ -49,7 +48,7 @@ impl Ndb {
 
         let path = Path::new(db_dir);
         if !path.exists() {
-            let _ = fs::create_dir_all(&path);
+            let _ = fs::create_dir_all(path);
         }
 
         let result = unsafe { bindings::ndb_init(&mut ndb, db_dir_cstr.as_ptr(), config.as_ptr()) };
@@ -144,7 +143,7 @@ impl Ndb {
             vec.set_len(res as usize);
         };
 
-        vec.into_iter().map(|n| NoteKey::new(n)).collect()
+        vec.into_iter().map(NoteKey::new).collect()
     }
 
     pub async fn wait_for_notes(&self, sub: &Subscription, max_notes: u32) -> Result<Vec<NoteKey>> {
@@ -172,7 +171,7 @@ impl Ndb {
         });
 
         match handle.await {
-            Ok(Ok(res)) => Ok(res.into_iter().map(|n| NoteKey::new(n)).collect()),
+            Ok(Ok(res)) => Ok(res.into_iter().map(NoteKey::new).collect()),
             Ok(Err(err)) => Err(err),
             Err(_) => Err(Error::SubscriptionError),
         }
@@ -299,7 +298,7 @@ impl Ndb {
 
     /// Get the underlying pointer to the context in C
     pub fn as_ptr(&self) -> *mut bindings::ndb {
-        return self.refs.ndb;
+        self.refs.ndb
     }
 }
 

src/ndb_profile.rs

@@ -1,5 +1,6 @@
-// automatically generated by the FlatBuffers compiler, do not modify
+#![allow(clippy::all)]
 
+// automatically generated by the FlatBuffers compiler, do not modify
 
 // @generated
 

src/ndb_str.rs

@@ -30,6 +30,10 @@ impl<'a> NdbStr<'a> {
         NdbStr { ndb_str, note }
     }
 
+    pub fn is_empty(&self) -> bool {
+        self.len() == 0
+    }
+
     pub fn len(&self) -> usize {
         if self.ndb_str.flag == (bindings::NDB_PACKED_ID as u8) {
             32

src/transaction.rs

@@ -47,10 +47,7 @@ impl bindings::ndb_txn {
         // just create something uninitialized. ndb_begin_query will initialize it for us
         let lmdb: *mut bindings::ndb_lmdb = std::ptr::null_mut();
         let mdb_txn: *mut ::std::os::raw::c_void = std::ptr::null_mut();
-        bindings::ndb_txn {
-            lmdb: lmdb,
-            mdb_txn: mdb_txn,
-        }
+        bindings::ndb_txn { lmdb, mdb_txn }
     }
 }