-
Notifications
You must be signed in to change notification settings - Fork 103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yurymkomarov - thanks for the high quality PR. This is really well done! I have a few minor comments to address. I also don't want to include the function.zip in the git repo itself. I see that you updated make/circleci to add that artifact which is fine. Maybe the readme can just have a step (once i publish release with the lambda.zip) that says to pull down the latest lambda.zip into your directory.
One more request. I pushed a new release and changed up the structure of this package. If you could migrate your terraform to the |
It was "hello world" lambda code. It's not possible to create lambda function without artifact ) |
Hello @dan-v , I've made a lot of updates. Please re-review my PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yurymkomarov - this is looking great! thanks for tackling the cli changes as well for function and role name. just a few comments/questions for you.
I'd also not mind placing this first in the README as the preferred method of deployment. This really streamlines the process quite nicely. Also, if I add a section to contributors for this project - would you like me to add you and if so anything you'd want me to link to? |
Okay, I will update README too. |
- minor fix in lambda configuration - update README
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Thanks for clarification and making those changes! I'm going to merge this in, and I'll work on updating the README with contributor section soon. Thanks a ton for this contribution.
You are always welcome ) Let me know if u will need help in TF updates/bug fixes ) |
Hello @dan-v !
I've created Terraform IaC configuration for awslambdaproxy application.
Please review my PR and let me know if u have any comments.