Skip to content
This repository has been archived by the owner on Mar 6, 2022. It is now read-only.

[IaC] Terraform #15

Merged
merged 9 commits into from
May 2, 2020
Merged

[IaC] Terraform #15

merged 9 commits into from
May 2, 2020

Conversation

yurymkomarov
Copy link
Contributor

Hello @dan-v !

I've created Terraform IaC configuration for awslambdaproxy application.

Please review my PR and let me know if u have any comments.

Copy link
Owner

@dan-v dan-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yurymkomarov - thanks for the high quality PR. This is really well done! I have a few minor comments to address. I also don't want to include the function.zip in the git repo itself. I see that you updated make/circleci to add that artifact which is fine. Maybe the readme can just have a step (once i publish release with the lambda.zip) that says to pull down the latest lambda.zip into your directory.

iac/terraform/data.tf Outdated Show resolved Hide resolved
iac/terraform/main.tf Outdated Show resolved Hide resolved
iac/terraform/main.tf Outdated Show resolved Hide resolved
iac/terraform/data.tf Outdated Show resolved Hide resolved
iac/terraform/data.tf Outdated Show resolved Hide resolved
iac/terraform/data.tf Outdated Show resolved Hide resolved
iac/terraform/main.tf Outdated Show resolved Hide resolved
iac/terraform/main.tf Outdated Show resolved Hide resolved
@dan-v
Copy link
Owner

dan-v commented May 1, 2020

One more request. I pushed a new release and changed up the structure of this package. If you could migrate your terraform to the deployment directory that would be ideal. I also included the lambda.zip file in latest release.

@yurymkomarov
Copy link
Contributor Author

yurymkomarov commented May 1, 2020

I also don't want to include the function.zip in the git repo itself

It was "hello world" lambda code. It's not possible to create lambda function without artifact )

@yurymkomarov yurymkomarov requested a review from dan-v May 2, 2020 12:36
@yurymkomarov
Copy link
Contributor Author

Hello @dan-v ,

I've made a lot of updates. Please re-review my PR.

Copy link
Owner

@dan-v dan-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yurymkomarov - this is looking great! thanks for tackling the cli changes as well for function and role name. just a few comments/questions for you.

deployment/terraform/main.tf Outdated Show resolved Hide resolved
deployment/terraform/lambda.tf Outdated Show resolved Hide resolved
deployment/terraform/lambda.tf Show resolved Hide resolved
@dan-v
Copy link
Owner

dan-v commented May 2, 2020

I'd also not mind placing this first in the README as the preferred method of deployment. This really streamlines the process quite nicely. Also, if I add a section to contributors for this project - would you like me to add you and if so anything you'd want me to link to?

@yurymkomarov
Copy link
Contributor Author

I'd also not mind placing this first in the README as the preferred method of deployment. This really streamlines the process quite nicely. Also, if I add a section to contributors for this project - would you like me to add you and if so anything you'd want me to link to?

Okay, I will update README too.
And yeah, you can add me as contributor. As link I will preferred github page (because I can't finish my personal website for... 4 months 🤣 )

- minor fix in lambda configuration
- update README
@yurymkomarov yurymkomarov requested a review from dan-v May 2, 2020 23:16
Copy link
Owner

@dan-v dan-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks for clarification and making those changes! I'm going to merge this in, and I'll work on updating the README with contributor section soon. Thanks a ton for this contribution.

@yurymkomarov
Copy link
Contributor Author

You are always welcome ) Let me know if u will need help in TF updates/bug fixes )

@dan-v dan-v merged commit d3a1182 into dan-v:master May 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants