Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Support for custom models in Resource Packs #296

Closed
vico93 opened this issue May 30, 2017 · 9 comments
Closed

[Question] Support for custom models in Resource Packs #296

vico93 opened this issue May 30, 2017 · 9 comments

Comments

@vico93
Copy link

vico93 commented May 30, 2017

Sorry to resurrect this issue, but does ComputerCraft 1.80 w/ Unborked 1.11.2 supports resource packs? I tried to adapt @ObloxCC 's model proposed in #202 (repository for the custom resource pack here) but it gives me the checkered texture and the computer won't rotate when placed:

2017-05-30_13 08 59

So my question is: Does ComputerCraft (specifically 1.80 w/ Unborked for 1.11.2) accepts custom models via resource packs or the model json is somewhat messed up?

Thanks for the patience

@dan200
Copy link
Owner

dan200 commented May 30, 2017 via email

@SquidDev
Copy link
Contributor

SquidDev commented May 30, 2017

In each file you define the textures as top, side and front. However the models just refer to 0, 1 and 2. The PR here looks like it uses the correct keys, so you might want to copy the files from there.

Also, unless you're using Plethora or CCTweaks, you can use the 1.11.2 PR which is significantly less hacky and has all of the new CC features included.

@vico93
Copy link
Author

vico93 commented May 30, 2017

Thanks a lot Mr. @SquidDev , i will switch to 1.11.2 PR, use the PR you've indicated and wait for CCTweaks and Plethora to be updated 😜

@vico93 vico93 closed this as completed May 30, 2017
@vico93
Copy link
Author

vico93 commented May 30, 2017

Actually i have a problem with the 1.11.2 CC fork @SquidDev have pointed.
https://gist.github.com/vpontin/4d370501df06d2fa1f8c45c878fe71f4
But i dont know where i would file an issue

@KnightMiner
Copy link

The build task in Gradle does not currently copy the luaj dependency into the jar. You will have to either use the deploy script or just copy the luaj jar from libs.

@ObloxCC
Copy link
Contributor

ObloxCC commented May 30, 2017

@vpontin If you want or need any help with this you can message/ask me. Also if you want I can fix the models to use the correct naming.

@vico93
Copy link
Author

vico93 commented May 31, 2017

@KnightMiner thanks a lot! I will try to build myself the fork.
@ObloxCC Sadly GitHub doesnt have any PM feature, so i'll throw up the problem here: When i place a Computer using your model, it always face the opposite direction it should be. If you look my repository you will see the only commit i've made was fixing 1.11.x item names, I tried to fix myself but no avail, and i've tried to open the model on the MrCrayfish's Model Creator, and it wont open.
Thank you a lot for offering to help me, and feel free to PR the repo with changes!

@vico93
Copy link
Author

vico93 commented Jun 3, 2017

@KnightMiner sadly i cant managed to build @SquidDev 's fork correctly, due to the problem Knight mentioned before (the compilation process doesnt account the luaj library).

@SquidDev
Copy link
Contributor

SquidDev commented Jun 3, 2017

@vpontin Sorry, until #186 is merged you'll also need to include luaj-jse-2.0.3.jar in the mods folder.

Alternatively, if you fancy building from source, you can use the ./deploy.sh script and use the jar in the deploy folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants