Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dominus troops cause 0loss battles when on the same hex #16

Closed
lvpcguru opened this issue Apr 5, 2019 · 2 comments
Closed

Dominus troops cause 0loss battles when on the same hex #16

lvpcguru opened this issue Apr 5, 2019 · 2 comments

Comments

@lvpcguru
Copy link
Contributor

lvpcguru commented Apr 5, 2019

noerror

error_attackAlerts

Attack alerts are generated any time the Dominus troops are in the same hex. This also adds a bunch of 0 loss battles to go with it.

an example:
https://dominusgame.net/game/GXz5pcQSvkpcR4Qu2/battle/XK4cBamorjW2PXrmA

@lvpcguru
Copy link
Contributor Author

lvpcguru commented Apr 5, 2019

Could this be related to at least the create new army in the same hex that already has one cause for this issue?

if (otherArmy._id != army._id) {

maybe add the armys player ID to the check here? like the army.isEnemy(otherArmy) checks in the battle jobs

if ((otherArmy._id != army._id) && (this.playerId == otherArmy.playerId)) {

lvpcguru added a commit to lvpcguru/dominus that referenced this issue Apr 8, 2019
Armys battle and alert if both armys are yours and you are Dominus.
dan335 added a commit that referenced this issue Apr 9, 2019
@dan335
Copy link
Owner

dan335 commented Apr 9, 2019

Thanks for figuring that out! Closing this.

@dan335 dan335 closed this as completed Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants