display higher rank types for high ranking players

danReynolds · Apr 2, 2018 · 4b82874 · 4b82874
1 parent d824beb
commit 4b82874
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 1 deletion.
diff --git a/app/controllers/summoners_controller.rb b/app/controllers/summoners_controller.rb
@@ -36,7 +36,7 @@ def performance_summary
       rank: queue.rank,
       winrate: queue.winrate,
       hot_streak: queue.hot_streak ? 'on' : 'not on',
-      elo: queue.elo.humanize,
+      elo: queue.display_elo.humanize,
       queue: queue.name
     })
 

diff --git a/app/models/ranked_queue.rb b/app/models/ranked_queue.rb
@@ -33,6 +33,10 @@ def elo
     ChampionGGApi::ELOS[@queue['tier'].to_sym] rescue nil
   end
 
+  def display_elo
+    ChampionGGApi::DISPLAY_ELOS[@queue['tier'].to_sym] rescue nil
+  end
+
   def lp
     @queue['leaguePoints']
   end

diff --git a/lib/champion_gg_api.rb b/lib/champion_gg_api.rb
@@ -14,6 +14,16 @@ class ChampionGGApi < ExternalApi
     CHALLENGER: 'PLATINUM_PLUS'
   }.freeze
 
+  DISPLAY_ELOS = {
+    BRONZE: 'BRONZE',
+    SILVER: 'SILVER',
+    GOLD: 'GOLD',
+    PLATINUM: 'PLATINUM',
+    MASTER: 'MASTER',
+    DIAMOND: 'DIAMOND',
+    CHALLENGER: 'CHALLENGER'
+  }.freeze
+
   # Metric Options
   # for builds and ability order performance in a role
   METRICS = {

diff --git a/spec/controllers/summoners_controller_spec.rb b/spec/controllers/summoners_controller_spec.rb
@@ -1550,6 +1550,12 @@
       expect(speech).to eq 'Wingilote is ranked Gold V with 84 LP in Solo Queue. The summoner currently has a 50.16% win rate.'
     end
 
+    it 'should use display elos for higher ranked players' do
+      external_response[0]['tier'] = 'MASTER'
+      post action, params: params
+      expect(speech).to eq 'Wingilote is ranked Master V with 84 LP in Solo Queue. The summoner currently has a 50.16% win rate.'
+    end
+
     it 'should vary the information by queue' do
       summoner_params[:queue] = 'RANKED_FLEX_SR'
       post action, params: params