Feature/move receipt routes #147

danReynolds · 2016-12-15T01:30:01Z

No description provided.

…lit controller

houndci-bot · 2016-12-15T01:30:09Z

spec/controllers/groceries/receipts_controller_spec.rb

+
+    context 'without an existing item' do
+      it 'should create the item and add it to the grocery list with the correct price' do
+        name = 'Bacon'


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2016-12-15T01:30:09Z

spec/controllers/groceries/receipts_controller_spec.rb

+    end
+
+    context 'without an existing item' do
+      it 'should create the item and add it to the grocery list with the correct price' do


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Line is too long. [90/80]

houndci-bot · 2016-12-15T01:30:09Z

spec/controllers/groceries/receipts_controller_spec.rb

+      end
+    end
+
+    context 'without an existing item' do


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2016-12-15T01:30:10Z

spec/controllers/groceries/receipts_controller_spec.rb

+      end
+
+      context 'with the item not on the grocery list' do
+        it 'should add the item to the list with the correct price' do


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2016-12-15T01:30:10Z

spec/controllers/groceries/receipts_controller_spec.rb

+        end
+      end
+
+      context 'with the item not on the grocery list' do


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2016-12-15T01:30:10Z

spec/controllers/groceries/receipts_controller_spec.rb

+      let(:name) { 'Bacon' }
+      let(:item) { create(:item, name: name) }
+      context 'with the item on the grocery list' do
+        it 'should set the price of the item to the match price' do


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2016-12-15T01:30:10Z

spec/controllers/groceries/receipts_controller_spec.rb

+    context 'with an existing item' do
+      let(:name) { 'Bacon' }
+      let(:item) { create(:item, name: name) }
+      context 'with the item on the grocery list' do


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2016-12-15T01:30:10Z

spec/controllers/groceries/receipts_controller_spec.rb

+    end
+
+    context 'with an existing item' do
+      let(:name) { 'Bacon' }


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2016-12-15T01:30:11Z

spec/controllers/groceries/receipts_controller_spec.rb

+      }.with_indifferent_access)
+    end
+
+    context 'with an existing item' do


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2016-12-15T01:30:11Z

spec/controllers/groceries/receipts_controller_spec.rb

+      {
+        matches: [
+          {
+            name: 'Bacon',


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2016-12-15T01:30:11Z

spec/controllers/groceries/receipts_controller_spec.rb

+    end
+  end
+
+  describe 'POST confirm' do


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2016-12-15T01:30:12Z

spec/controllers/groceries/receipts_controller_spec.rb

-        expect(results['total']).to eq 10.40
-        expect(results['matches'].map! { |match| match.slice('name', 'price') }).to eq expected_matches
+        expect(matches['total']).to eq 10.40
+        expect(matches['list'].map! { |match| match.slice('name', 'price') }).to eq expected_matches


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Line is too long. [100/80]

houndci-bot · 2016-12-15T01:30:12Z

spec/controllers/groceries/receipts_controller_spec.rb


-        expect(results['total']).to eq 10.40
-        expect(results['matches'].map! { |match| match.slice('name', 'price') }).to eq expected_matches
+        expect(matches['total']).to eq 10.40


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2016-12-15T01:30:12Z

spec/controllers/groceries/receipts_controller_spec.rb

-        expect(results['total']).to eq 44.45
-        expect(results['matches'].map! { |match| match.slice('name', 'price') }).to eq expected_matches
+        expect(matches['total']).to eq 44.45
+        expect(matches['list'].map! { |match| match.slice('name', 'price') }).to eq expected_matches


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Line is too long. [100/80]

houndci-bot · 2016-12-15T01:30:12Z

spec/controllers/groceries/receipts_controller_spec.rb


-        expect(results['total']).to eq 44.45
-        expect(results['matches'].map! { |match| match.slice('name', 'price') }).to eq expected_matches
+        expect(matches['total']).to eq 44.45


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2016-12-15T01:30:13Z

spec/controllers/groceries/receipts_controller_spec.rb

-        expect(results['total']).to eq 0
-        expect(results['matches'].map! { |match| match.slice('name', 'price', 'new') }).to eq expected_matches
+        expect(matches['total']).to eq 0
+        expect(matches['list'].map! { |match| match.slice('name', 'price', 'new') }).to eq expected_matches


Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Line is too long. [107/80]

coveralls · 2016-12-15T01:33:02Z

Coverage decreased (-0.04%) to 97.907% when pulling 274fed5 on feature/moveReceiptRoutes into 8b5fc5e on master.

coveralls · 2016-12-15T02:10:18Z

Coverage decreased (-0.04%) to 97.907% when pulling 4976f2d on feature/moveReceiptRoutes into 8b5fc5e on master.

Feature/move receipt routes

danReynolds added 4 commits December 14, 2016 17:02

refactor receipt show and confirm to receipt controller

851f9b4

ensure that default group is set for current user if none already

f82b272

update client side routing and view template for receipts to under sp…

fefb13e

…lit controller

hack comment

274fed5

danReynolds added the in progress label Dec 15, 2016

houndci-bot reviewed Dec 15, 2016

View reviewed changes

danReynolds added 2 commits December 14, 2016 17:36

fix test for route moved to receipt controller

4bf2433

remove routing test for receipt split controller

4976f2d

danReynolds merged commit 9336584 into master Dec 15, 2016

danReynolds deleted the feature/moveReceiptRoutes branch December 15, 2016 06:09

danReynolds removed the in progress label Dec 15, 2016

danReynolds added a commit that referenced this pull request May 19, 2017

Merge pull request #147 from danReynolds/feature/moveReceiptRoutes

c6fc694

Feature/move receipt routes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/move receipt routes #147

Feature/move receipt routes #147

danReynolds commented Dec 15, 2016

houndci-bot Dec 15, 2016

houndci-bot Dec 15, 2016

houndci-bot Dec 15, 2016

houndci-bot Dec 15, 2016

houndci-bot Dec 15, 2016

houndci-bot Dec 15, 2016

houndci-bot Dec 15, 2016

houndci-bot Dec 15, 2016

houndci-bot Dec 15, 2016

houndci-bot Dec 15, 2016

houndci-bot Dec 15, 2016

houndci-bot Dec 15, 2016

houndci-bot Dec 15, 2016

houndci-bot Dec 15, 2016

houndci-bot Dec 15, 2016

houndci-bot Dec 15, 2016

coveralls commented Dec 15, 2016

coveralls commented Dec 15, 2016

Feature/move receipt routes #147

Feature/move receipt routes #147

Conversation

danReynolds commented Dec 15, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Dec 15, 2016

coveralls commented Dec 15, 2016