fix(Lint): TabIndex to positive for keyboard tab order [#68]

danactive · Dec 11, 2016 · 1c45f87 · 1c45f87
1 parent 14a597f
commit 1c45f87
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -14,8 +14,9 @@
 ## Pull Requests (code review)
 * Do not bump version or update changelog as it's manually triggered when released
 * Enforced rules for new Pull Requests
-	* Pull request description must include verification steps [read more...](https://gitmagic.io/rules/#/pull-request/body-must-include-verification-steps)
 	* Commit message subject must include a GitHub issue [read more...](https://gitmagic.io/rules/#/commit/subject-must-include-github-issue)
+	* Pull request title must be in imperative, present tense (e.g. "add", "fix", "change") [read more...](https://gitmagic.io/rules/#/pull-request/subject-must-be-in-tense) 
+	* Pull request description must include verification steps [read more...](https://gitmagic.io/rules/#/pull-request/body-must-include-verification-steps)
 * Write unit tests to match existing test coverage
 * More with GitHub.com documentation on [Contributing to a Project](https://guides.github.com/activities/contributing-to-open-source/#contributing)
 

diff --git a/plugins/editAlbum/views/gallery.jsx b/plugins/editAlbum/views/gallery.jsx
@@ -1,7 +1,7 @@
 /* global GetGalleryNames */
 const React = require('react');
 
-// eslint-disable jsx-a11y/tabindex-no-positive
+/* eslint-disable jsx-a11y/tabindex-no-positive */
 class GalleryDropdown extends React.Component {
   constructor(props) {
     super(props);

diff --git a/plugins/editAlbum/views/page.jsx b/plugins/editAlbum/views/page.jsx
@@ -1,6 +1,6 @@
 const React = require('react');
 
-// eslint-disable jsx-a11y/tabindex-no-positive
+/* eslint-disable jsx-a11y/tabindex-no-positive */
 function Page(props) {
   return (
     <html lang="en">