Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No response received from Play method EventSocket class #10

Closed
padmanabanravikumar opened this issue Mar 7, 2015 · 1 comment
Closed

Comments

@padmanabanravikumar
Copy link

When Play method called just after hang up occurs then there is no response from method.

I've found the following log for this call.

2015-03-07 15:40:26.9263|DEBUG|NEventSocket.InboundSocket|CommandReply received
[-ERR invalid session id [c1cdaeae-ebb0-4f3f-8f75-0f673bfbc046]] for [sendmsg c1
cdaeae-ebb0-4f3f-8f75-0f673bfbc046
Event-UUID: 0cbc2a67-8591-49bc-8f64-abe414744c4f
call-command: execute
execute-app-name: playback
content-type: text/plain
content-length: 29

I think there is a problem in ExecuteApplication method. it only returns response after receiving ChannelExecuteComplete event.

danbarua added a commit that referenced this issue Mar 9, 2015
danbarua added a commit that referenced this issue Mar 9, 2015
Added test for application completion
@danbarua
Copy link
Owner

danbarua commented Mar 9, 2015

@padmanabanravikumar Thanks for reporting the issue, we'll now return a null EventMessage in this case. I'm not entirely happy with this design, as the CommandReply error message would essentially be swallowed by this. (You'll still get an ApplicationResult with success == false.) I need to come back and revisit this at some point to make it better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants