Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChannelState #47

Closed
gregoriusus opened this issue Jun 24, 2016 · 2 comments
Closed

ChannelState #47

gregoriusus opened this issue Jun 24, 2016 · 2 comments

Comments

@gregoriusus
Copy link

CchannelState variable can be null. Header doesn't have value in CUSTOM events
Can you plese set ChannelState property to nullable like AnswerState.

Thank you!
danbarua added a commit that referenced this issue Jun 30, 2016
@danbarua
re #47 make ChannelState property on EventMessage nullable
e6784e7
@danbarua
Copy link
Owner

Yep, not everyone is using this for Channel Events, thanks for the catch.

danbarua added a commit that referenced this issue Jun 30, 2016
@danbarua
re #47 handle nullable ChannelState in BasicChannel
86b820d
@danbarua danbarua mentioned this issue Sep 13, 2016
Closed
danbarua added a commit that referenced this issue Sep 13, 2016
@danbarua
re #57 re #47 Split ChannelEvents from basic Events, bump to v2.1.0
e846feb
@danbarua
Copy link
Owner

@gregoriusus I am taking a different approach now for V2 - socket.Events contains basic Event messages, socket.ChannelEvents contains channel events. So issues like this should not come up again in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danbarua @gregoriusus