Feature/GitHub actions #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danbilokha
requested review from
jmelnych and
Proladge
and removed request for
jmelnych
Proladge
reviewed
Apr 17, 2020
| @@ -1,4 +1,4 @@ | |||
| const ngrok = require('ngrok'); | |||
| import * as ngrok from 'ngrok'; | |||
| @@ -1,14 +1,25 @@ | |||
| import * as request from 'supertest'; | |||
| import { expect } from 'chai'; | |||
| import * as app from '../../index'; | |||
| import {app} from '../../index'; | |||
infrastructure/demo-release.bat
Outdated
| @@ -1,5 +1,5 @@ | |||
| CALL cd .. | |||
There was a problem hiding this comment.
I'd move this set of comamnds to single bat.
And then jst have kind demo.bat which says relase.bat demo-covid19livebot
inside release bat it would be
CALL heroku container:push web --app=%1
CALL heroku container:release web --app=%1
CALL heroku open --app=%1
5b28cd6
to
51acffc
Compare
Proladge
reviewed
Apr 17, 2020
.github/workflows/reports.yml
Outdated
| - name: Coveralls | ||
| uses: coverallsapp/github-action@master | ||
| with: | ||
| github-token: ${{ secrets.GITHUB_TOKEN }} |
| @@ -1,5 +0,0 @@ | |||
| CALL cd .. | |||
There was a problem hiding this comment.
I actually meant nor toremove this file,
But make it
release.bat demo-covid19livebot
and create a seperate one for prod
same way to be prod.release.bat
| @@ -1,3 +1,5 @@ | |||
| [](https://coveralls.io/github/danbilokha/covid19liveupdates?branch=master) | |||
There was a problem hiding this comment.
34% 👍 Even though we're testing only 1 file
There was a problem hiding this comment.
Thant's because it hasn't been mocked, I suppose
danbilokha
force-pushed
the
feature/github_actions
branch
from
51acffc
to
5d9aa01
Compare
danbilokha
force-pushed
the
feature/github_actions
branch
from
5d9aa01
to
14fcbc2
Compare
Closed
Proladge
approved these changes
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.