Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving a note that is not visible saves it in the wrong position #1623

Closed
ToksT opened this issue May 15, 2013 · 4 comments
Closed

Saving a note that is not visible saves it in the wrong position #1623

ToksT opened this issue May 15, 2013 · 4 comments
Labels

Comments

@ToksT
Copy link
Contributor

ToksT commented May 15, 2013

  • A note editing window is opened
  • Note visibility is toggled by clicking the image
  • A note is saved

That will cause the saved note to be saved at the wrong coordinates (only visible after refreshing the page).

@Lightforger
Copy link
Contributor

There are a few other options as well, but that seemed best (even if it may not be clear why "visibility" is used instead of the normal "display:none" ~ which is why i'm making this comment :3)

visibility:hidden does not remove it from document flow (eg, does not collapse the space the element takes up - which doesn't matter as we are using "position:absolute" anyway) - if display:none is used, ".position()" fails.

Other options:

  • Quickly toggling the display of the container (may cause redraws or flicker)
  • Getting the data from the css instead of from ".position()" - css is only available if a note is dragged/resized.

@ToksT
Copy link
Contributor Author

ToksT commented May 16, 2013

Bugs with that fix:

  • Creating notes will toggle the visibility of all notes when the mouse is released.
  • Clicking anywhere after pressing N will always create a note, unconditionally (eg. outside the image, when you're trying to click the Save button, etc).

@ToksT ToksT reopened this May 16, 2013
@Lightforger
Copy link
Contributor

Try this fix 55ceb19 - code was generating errors

@ToksT
Copy link
Contributor Author

ToksT commented May 16, 2013

Looks good. Quotation marks are sneaky like that :)

@ToksT ToksT closed this as completed May 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants