Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favorite groups #2416

Merged
merged 4 commits into from Jun 25, 2015
Merged

Favorite groups #2416

merged 4 commits into from Jun 25, 2015

Conversation

ToksT
Copy link
Contributor

@ToksT ToksT commented Jun 25, 2015

implements #635

  • Basic members can have 3 groups, gold can have 5, platinum can have 10 (arbitrarily decided)
  • Each favorite group can have up to 10,000 posts (arbitrarily decided)
  • Favorite groups can be viewed by anyone but only edited/deleted by their creator
  • Can add posts to favgroups like pools: either edit the list of ids or type favgroup:[name or id] in the post's tags
  • There is a favgroup:[id] search metatag to allow advanced searches. This is implemented with posts.id IN, which I would have expected to be slow for large favgroups, but is surprisingly fast. Not slow even with thousands of posts in the favgroup.
  • Can browse through favgroups like pools
  • There's a link to your own favgroups in the subnavbar, and to other people's via their profile

@ToksT ToksT added the Feature label Jun 25, 2015
r888888888 added a commit that referenced this pull request Jun 25, 2015
@r888888888 r888888888 merged commit d803c68 into master Jun 25, 2015
@r888888888
Copy link
Collaborator

Only concern is this table blowing up in size but it probably won't be as bad as favorites. For that reason I think being more aggressive with the limiting is probably a good idea, can always raise them later if usage isn't high.

@r888888888 r888888888 deleted the favorite-groups branch August 26, 2016 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants