Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Artist ID and Wiki ID usable in queries #2646

Closed
reiyasona opened this issue Aug 28, 2016 · 7 comments
Closed

Make Artist ID and Wiki ID usable in queries #2646

reiyasona opened this issue Aug 28, 2016 · 7 comments

Comments

@reiyasona
Copy link

Artist ID: artid:<id>
Wiki ID: wikiid:<id>

Example:
artid:8683 wikiid:4817 = redjuice skirt (redjuice also has Wiki ID 6092)

@Type-kun
Copy link
Collaborator

Out of curiosity, where would that be useful?

@reiyasona
Copy link
Author

It would be useful in combination with tag subscriptions and saved searches to guarantee consistent results. A tag's notation (e.g. an artist's name) can change over time. If the creation of an alias is left out or forgotten, old queries won't hit their target anymore.

@BrokenEagle
Copy link
Collaborator

In most cases that would hold true. However sometimes artist entries and wiki entries get merged because of duplicates, and there's no guarantee of which one will get deleted in the merging, so the ID numbers could also get changed.

I'm not sure there's a way to guarantee that an artist or wiki would always be tied to a certain ID...?

@reiyasona
Copy link
Author

Merge scenario:

Artist IDs and Wiki IDs don't get reused, right? If two tags are getting merged, we can simply set a pointer.

ID 00001 and ID 00002 -> merge -> set pointer to superior ID

Purge scenario:

If a tag was completely deleted without the creation of an alias, there should be some kind of warning for everyone who is using this tag in a subscription or saved search.

Note:

  • All artist tags have an Artist ID.
  • All tags (also artist tags) will only have a Wiki ID if a wiki entry is created.

@evazion
Copy link
Member

evazion commented Sep 3, 2016

I think the real problem is people moving artists without requesting aliases. People shouldn't be forced to use artid:1234 in their subscriptions/saved searches to protect themselves from tag moves. Instead we should encourage people to move tags the right way: request aliases to move large tags and mass updates for small or ambiguous tags. This would require fixing #2251 first though.

@reiyasona
Copy link
Author

Okay, I understand. It's better to fix the real problem than to keep working around it.

@stale
Copy link

stale bot commented Jul 30, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 30, 2019
@evazion evazion closed this as completed Jul 30, 2019
@evazion evazion removed the stale label Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants