Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing Notes Creates New Notes Stacked On Top Of Each Other #2747

Closed
BrokenEagle opened this issue Oct 31, 2016 · 2 comments
Closed

Editing Notes Creates New Notes Stacked On Top Of Each Other #2747

BrokenEagle opened this issue Oct 31, 2016 · 2 comments

Comments

@BrokenEagle
Copy link
Collaborator

BrokenEagle commented Oct 31, 2016

Shounen_Fake noticed this issue on post #2527315, a post that I had translated. It had triple stacked notes in the same location. I thought it must've been an error that I made, but then I came upon post #2528809 with the same issue. This one had quadruple stacked notes. I've already deleted the extras, but you can still see them in it's history.

http://danbooru.donmai.us/note_versions?search%5Bpost_id%5D=2527315
http://danbooru.donmai.us/note_versions?search%5Bpost_id%5D=2528809

I did remember when translating post #2527315 that after I had hit the Save button, the outline of the text box remained red instead of going black. So I then retested this on testbooru, first creating a note, then opening it up for editing without reloading and modifying it before resaving it again. The end effect is that it ended up creating 2 notes in the same location stacked on top of each other. You can see this demonstrated at the following link.

http://testbooru.donmai.us/posts/4

@evazion
Copy link
Member

evazion commented Oct 31, 2016

I think PR #2748 fixes this, but I don't use notes so I'm not positive. I have it running on http://devbooru.evazion.ml:3000/, can you test it?

@BrokenEagle
Copy link
Collaborator Author

Tested it on http://devbooru.evazion.ml:3000/posts/1 and it works as it should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants