Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable post version merging #2910

Closed
Type-kun opened this issue Mar 2, 2017 · 3 comments
Closed

Re-enable post version merging #2910

Type-kun opened this issue Mar 2, 2017 · 3 comments

Comments

@Type-kun
Copy link
Collaborator

Type-kun commented Mar 2, 2017

I don't really understand why this was disabled, anyway. Is it too hard to replace a record in offloaded database? Either way, it seems to be an universal agreement in issues topic that versions without merging create too much clutter and put unnecessary pressure on taggers.

@evazion
Copy link
Member

evazion commented Mar 3, 2017

I think they could be stored unmerged in the db but merged on-the-fly for display purposes. Just before they're rendered in the view, do a pass over the array and merge consecutive edits by the same person into a single (unsaved) record.

Not merging them in the db does make the API easier to consume. As it was, if you were reading /post_versions.json you had to wait 2 hours after seeing an edit to be 100% sure the post version was finalized.

@Type-kun
Copy link
Collaborator Author

Type-kun commented Mar 3, 2017

I think they could be stored unmerged in the db but merged on-the-fly for display purposes. Just before they're rendered in the view, do a pass over the array and merge consecutive edits by the same person into a single (unsaved) record.

This doesn't work well with normal numbered pagination, unfortunately.

@r888888888
Copy link
Collaborator

The logic for it was kind of tricky because the diffs are stored now. I will re-enable it for pools first to see if it works correctly. The changes will have to be made in the Archives app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants