Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upload batch view and related tag script (#3366) #3367

Merged
merged 1 commit into from Nov 15, 2017

Conversation

BrokenEagle
Copy link
Collaborator

@BrokenEagle BrokenEagle commented Nov 14, 2017

Fixes #3366, which was caused because the batch view unknowingly had the incorrect value of #c-uploads #a-new, which caused it to run the related tag Javascript when it shouldn't.

This therefore fixes two problems present:

  1. Renames batch view to the correct ID of #c-uploads #a-batch
  2. Wraps the JSON parse in related tags with a try/catch for all other unknown cases

As a side note, this bears going through the remaining views and checking that they have the correct IDs as well, though I didn't want to do that as part of an urgent fix request.

@r888888888 r888888888 merged commit e79af4c into danbooru:master Nov 15, 2017
@BrokenEagle BrokenEagle deleted the fix-3366 branch December 21, 2017 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Open all links in new window" is broken in the batch bookmarklet
2 participants