Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch commentary not creating fully formed textile links #3384

Closed
BrokenEagle opened this issue Nov 18, 2017 · 3 comments
Closed

Fetch commentary not creating fully formed textile links #3384

BrokenEagle opened this issue Nov 18, 2017 · 3 comments
Assignees
@evazion
Labels
Bug

Comments

@BrokenEagle
Copy link
Collaborator

Brought up by Chinatsu. This issue was showing up on post #2922731, though in case its been updated, I've included the Artist Commentary history for that post below.

https://danbooru.donmai.us/artist_commentary_versions?search%5Bpost_id%5D=2922731
@evazion evazion self-assigned this Nov 18, 2017
@evazion evazion added the Bug label Nov 18, 2017
@evazion
Copy link
Member

evazion commented Nov 18, 2017 •
edited

It looks like the links on the DeviantArt post are missing the http://. They look like this: https://www.deviantart.com/users/outgoing?www.inprnt.com/gallery/teemutaiga/kisu.

@BrokenEagle
Copy link
Collaborator Author

Yeah, FWIW, I've seen other sites do similar things. Besides the above, I've also seen only the protocol portion missing, as in //www.inprnt.com But at least this seems to be a valid href, unlike the above.

https://stackoverflow.com/questions/8951423/html-links-without-http-protocol

@evazion
Copy link
Member

evazion commented Nov 18, 2017

This fixes it for DeviantArt, let me know if it's broken on other sites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evazion evazion

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@evazion @BrokenEagle