Fix race condition when adding posts to favgroups #3403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding or removing a post id to a favgroup's post_ids string is non-atomic. Lock it to prevent simultaneous updates to the same favgroup from clobbering each other. Same bug as danbooru#3091.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a race condition when adding posts to favgroups. If you tried to add posts to a favgroup very quickly using a script, some posts wouldn't get added. Adding a post to a favgroup was non-atomic, so some updates would clobber others.
This is the same bug as the pool bug from #3091 (fixed in 31b58e1).